[PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7

Andreas Schwab posted 1 patch 11 months, 1 week ago
arch/powerpc/kernel/prom_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
Posted by Andreas Schwab 11 months, 1 week ago
Similar to the PowerMac3,1, the PowerBook6,7 is missing the #size-cells
property on the i2s node.

Depends-on: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
 arch/powerpc/kernel/prom_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 8e776ba39497..24b1523eeea8 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -2898,11 +2898,11 @@ static void __init fixup_device_tree_pmac(void)
 	char type[8];
 	phandle node;
 
-	// Some pmacs are missing #size-cells on escc nodes
+	// Some pmacs are missing #size-cells on escc or i2s nodes
 	for (node = 0; prom_next_node(&node); ) {
 		type[0] = '\0';
 		prom_getprop(node, "device_type", type, sizeof(type));
-		if (prom_strcmp(type, "escc"))
+		if (prom_strcmp(type, "escc") && prom_strcmp(type, "i2s"))
 			continue;
 
 		if (prom_getproplen(node, "#size-cells") != PROM_ERROR)
-- 
2.48.0


-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
Posted by Madhavan Srinivasan 9 months, 1 week ago
On Mon, 13 Jan 2025 18:19:09 +0100, Andreas Schwab wrote:
> Similar to the PowerMac3,1, the PowerBook6,7 is missing the #size-cells
> property on the i2s node.
> 
> 

Applied to powerpc/next.

[1/1] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
      https://git.kernel.org/powerpc/c/7e67ef889c9ab7246547db73d524459f47403a77

Thanks
Re: [PATCH] powerpc/prom_init: Fixup missing #size-cells on PowerBook6,7
Posted by Rob Herring 11 months ago
On Mon, Jan 13, 2025 at 11:19 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> Similar to the PowerMac3,1, the PowerBook6,7 is missing the #size-cells
> property on the i2s node.
>
> Depends-on: 045b14ca5c36 ("of: WARN on deprecated #address-cells/#size-cells handling")
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
>  arch/powerpc/kernel/prom_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Rob Herring (Arm) <robh@kernel.org>