powerpc/trace: Restrict hash_fault trace event to HASH MMU

[PATCH] powerpc/trace: Restrict hash_fault trace event to HASH MMU

Posted by Christophe Leroy 1 year, 11 months ago

'perf list' on powerpc 8xx shows an event named "1:hash_fault".

This event is pointless because trace_hash_fault() is called only
from mm/book3s64/hash_utils.c

Only define it when CONFIG_PPC_64S_HASH_MMU is selected.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
 arch/powerpc/include/asm/trace.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/trace.h b/arch/powerpc/include/asm/trace.h
index 82cc2c6704e6..d9ac3a4f46e1 100644
--- a/arch/powerpc/include/asm/trace.h
+++ b/arch/powerpc/include/asm/trace.h
@@ -267,6 +267,7 @@ TRACE_EVENT_FN(opal_exit,
 );
 #endif
 
+#ifdef CONFIG_PPC_64S_HASH_MMU
 TRACE_EVENT(hash_fault,
 
 	    TP_PROTO(unsigned long addr, unsigned long access, unsigned long trap),
@@ -286,7 +287,7 @@ TRACE_EVENT(hash_fault,
 	    TP_printk("hash fault with addr 0x%lx and access = 0x%lx trap = 0x%lx",
 		      __entry->addr, __entry->access, __entry->trap)
 );
-
+#endif
 
 TRACE_EVENT(tlbie,
 
-- 
2.43.0

Re: [PATCH] powerpc/trace: Restrict hash_fault trace event to HASH MMU

Posted by Michael Ellerman 1 year, 11 months ago

On Fri, 16 Feb 2024 10:46:43 +0100, Christophe Leroy wrote:
> 'perf list' on powerpc 8xx shows an event named "1:hash_fault".
> 
> This event is pointless because trace_hash_fault() is called only
> from mm/book3s64/hash_utils.c
> 
> Only define it when CONFIG_PPC_64S_HASH_MMU is selected.
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/trace: Restrict hash_fault trace event to HASH MMU
      https://git.kernel.org/powerpc/c/9e00743aba832f3f30ecb017d3345baf1f372140

cheers