cpufreq: Move endif to the end of Kconfig file

[PATCH] cpufreq: Move endif to the end of Kconfig file

Posted by Viresh Kumar 1 year ago

It is possible to enable few cpufreq drivers, without the framework
being enabled. This happened due to a bug while moving the entries
earlier. Fix it.

Fixes: 7ee1378736f0 ("cpufreq: Move CPPC configs to common Kconfig and add RISC-V")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index ea9afdc119fb..d64b07ec48e5 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -325,8 +325,6 @@ config QORIQ_CPUFREQ
 	  This adds the CPUFreq driver support for Freescale QorIQ SoCs
 	  which are capable of changing the CPU's frequency dynamically.
 
-endif
-
 config ACPI_CPPC_CPUFREQ
 	tristate "CPUFreq driver based on the ACPI CPPC spec"
 	depends on ACPI_PROCESSOR
@@ -355,4 +353,6 @@ config ACPI_CPPC_CPUFREQ_FIE
 
 	  If in doubt, say N.
 
+endif
+
 endmenu
-- 
2.31.1.272.g89b43f80a514

Re: [PATCH] cpufreq: Move endif to the end of Kconfig file

Posted by Sudeep Holla 1 year ago

On Fri, Jan 10, 2025 at 11:23:10AM +0530, Viresh Kumar wrote:
> It is possible to enable few cpufreq drivers, without the framework
> being enabled. This happened due to a bug while moving the entries
> earlier. Fix it.
>

Surprising to see how randconfigs has not managed to catch this so far.

Anyways,

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

> Fixes: 7ee1378736f0 ("cpufreq: Move CPPC configs to common Kconfig and add RISC-V")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/cpufreq/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index ea9afdc119fb..d64b07ec48e5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -325,8 +325,6 @@ config QORIQ_CPUFREQ
>  	  This adds the CPUFreq driver support for Freescale QorIQ SoCs
>  	  which are capable of changing the CPU's frequency dynamically.
>  
> -endif
> -
>  config ACPI_CPPC_CPUFREQ
>  	tristate "CPUFreq driver based on the ACPI CPPC spec"
>  	depends on ACPI_PROCESSOR
> @@ -355,4 +353,6 @@ config ACPI_CPPC_CPUFREQ_FIE
>  
>  	  If in doubt, say N.
>  
> +endif
> +
>  endmenu
> -- 
> 2.31.1.272.g89b43f80a514
> 

-- 
Regards,
Sudeep

Re: [PATCH] cpufreq: Move endif to the end of Kconfig file

Posted by Rafael J. Wysocki 1 year ago

On Fri, Jan 10, 2025 at 3:43 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Fri, Jan 10, 2025 at 11:23:10AM +0530, Viresh Kumar wrote:
> > It is possible to enable few cpufreq drivers, without the framework
> > being enabled. This happened due to a bug while moving the entries
> > earlier. Fix it.
> >
>
> Surprising to see how randconfigs has not managed to catch this so far.
>
> Anyways,
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

Applied as a fix for 6.13, thanks!

Re: [PATCH] cpufreq: Move endif to the end of Kconfig file

Posted by Sunil V L 1 year ago

On Fri, Jan 10, 2025 at 11:23:10AM +0530, Viresh Kumar wrote:
> It is possible to enable few cpufreq drivers, without the framework
> being enabled. This happened due to a bug while moving the entries
> earlier. Fix it.
> 
> Fixes: 7ee1378736f0 ("cpufreq: Move CPPC configs to common Kconfig and add RISC-V")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/cpufreq/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index ea9afdc119fb..d64b07ec48e5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -325,8 +325,6 @@ config QORIQ_CPUFREQ
>  	  This adds the CPUFreq driver support for Freescale QorIQ SoCs
>  	  which are capable of changing the CPU's frequency dynamically.
>  
> -endif
> -
>  config ACPI_CPPC_CPUFREQ
>  	tristate "CPUFreq driver based on the ACPI CPPC spec"
>  	depends on ACPI_PROCESSOR
> @@ -355,4 +353,6 @@ config ACPI_CPPC_CPUFREQ_FIE
>  
>  	  If in doubt, say N.
>  
> +endif
> +
>  endmenu
Thanks! Viresh for fixing this.

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Re: [PATCH] cpufreq: Move endif to the end of Kconfig file

Posted by Pierre Gondois 1 year ago

Hello Viresh,

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

On 1/10/25 06:53, Viresh Kumar wrote:
> It is possible to enable few cpufreq drivers, without the framework
> being enabled. This happened due to a bug while moving the entries
> earlier. Fix it.
> 
> Fixes: 7ee1378736f0 ("cpufreq: Move CPPC configs to common Kconfig and add RISC-V")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>   drivers/cpufreq/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index ea9afdc119fb..d64b07ec48e5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -325,8 +325,6 @@ config QORIQ_CPUFREQ
>   	  This adds the CPUFreq driver support for Freescale QorIQ SoCs
>   	  which are capable of changing the CPU's frequency dynamically.
>   
> -endif
> -
>   config ACPI_CPPC_CPUFREQ
>   	tristate "CPUFreq driver based on the ACPI CPPC spec"
>   	depends on ACPI_PROCESSOR
> @@ -355,4 +353,6 @@ config ACPI_CPPC_CPUFREQ_FIE
>   
>   	  If in doubt, say N.
>   
> +endif
> +
>   endmenu