[PATCH v2 5/8] thermal/debugfs: Adjust check for trips without statistics in tze_seq_show()

Rafael J. Wysocki posted 1 patch 1 year, 6 months ago
drivers/thermal/thermal_debugfs.c |    3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH v2 5/8] thermal/debugfs: Adjust check for trips without statistics in tze_seq_show()
Posted by Rafael J. Wysocki 1 year, 6 months ago
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Initialize the trip_temp field in struct trip_stats to
THERMAL_TEMP_INVALID and adjust the check for trips without
statistics in tze_seq_show() to look at that field instead of
comparing min and max.

This will mostly be useful to simplify subsequent changes.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

v1 -> v2: New patch.

---
 drivers/thermal/thermal_debugfs.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-pm/drivers/thermal/thermal_debugfs.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_debugfs.c
+++ linux-pm/drivers/thermal/thermal_debugfs.c
@@ -563,6 +563,7 @@ static struct tz_episode *thermal_debugf
 	tze->duration = KTIME_MIN;
 
 	for (i = 0; i < tz->num_trips; i++) {
+		tze->trip_stats[i].trip_temp = THERMAL_TEMP_INVALID;
 		tze->trip_stats[i].min = INT_MAX;
 		tze->trip_stats[i].max = INT_MIN;
 	}
@@ -818,7 +819,7 @@ static int tze_seq_show(struct seq_file
 		trip_stats = &tze->trip_stats[trip_id];
 
 		/* Skip trips without any stats. */
-		if (trip_stats->min > trip_stats->max)
+		if (trip_stats->trip_temp == THERMAL_TEMP_INVALID)
 			continue;
 
 		if (trip->type == THERMAL_TRIP_PASSIVE)
Re: [PATCH v2 5/8] thermal/debugfs: Adjust check for trips without statistics in tze_seq_show()
Posted by Daniel Lezcano 1 year, 6 months ago
On 28/05/2024 16:57, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Initialize the trip_temp field in struct trip_stats to
> THERMAL_TEMP_INVALID and adjust the check for trips without
> statistics in tze_seq_show() to look at that field instead of
> comparing min and max.
> 
> This will mostly be useful to simplify subsequent changes.
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog