brcm80211: BRCM_TRACING should depend on TRACING

[PATCH] brcm80211: BRCM_TRACING should depend on TRACING

Posted by Geert Uytterhoeven 2 months ago

When tracing is disabled, there is no point in asking the user about
enabling Broadcom wireless device tracing.

Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be enabled separately from debug")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/wireless/broadcom/brcm80211/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/Kconfig b/drivers/net/wireless/broadcom/brcm80211/Kconfig
index 3a1a35b5672f1a27..19d0c003f6262675 100644
--- a/drivers/net/wireless/broadcom/brcm80211/Kconfig
+++ b/drivers/net/wireless/broadcom/brcm80211/Kconfig
@@ -27,6 +27,7 @@ source "drivers/net/wireless/broadcom/brcm80211/brcmfmac/Kconfig"
 config BRCM_TRACING
 	bool "Broadcom device tracing"
 	depends on BRCMSMAC || BRCMFMAC
+	depends on TRACING
 	help
 	  If you say Y here, the Broadcom wireless drivers will register
 	  with ftrace to dump event information into the trace ringbuffer.
-- 
2.34.1

Re: [PATCH] brcm80211: BRCM_TRACING should depend on TRACING

Posted by Arend Van Spriel 2 months ago

On September 24, 2024 2:09:35 PM Geert Uytterhoeven <geert@linux-m68k.org> 
wrote:

> When tracing is disabled, there is no point in asking the user about
> enabling Broadcom wireless device tracing.
>
> Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be enabled 
> separately from debug")
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/net/wireless/broadcom/brcm80211/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Re: [PATCH] brcm80211: BRCM_TRACING should depend on TRACING

Posted by Kalle Valo 2 months ago

Arend Van Spriel <arend.vanspriel@broadcom.com> writes:

> On September 24, 2024 2:09:35 PM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> When tracing is disabled, there is no point in asking the user about
>> enabling Broadcom wireless device tracing.
>>
>> Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be
>> enabled separately from debug")
>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

I'm planning to take this to wireless and I'll add 'wifi:' to the title.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches