MIPS: Alchemy: Fix an out-of-bound access in db1550_dev_setup()

[PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1550_dev_setup()

Posted by Christophe JAILLET 1 year, 11 months ago

When calling spi_register_board_info(),

Fixes: f869d42e580f ("MIPS: Alchemy: Improved DB1550 support, with audio and serial busses.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 arch/mips/alchemy/devboards/db1550.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/alchemy/devboards/db1550.c b/arch/mips/alchemy/devboards/db1550.c
index fd91d9c9a252..6c6837181f55 100644
--- a/arch/mips/alchemy/devboards/db1550.c
+++ b/arch/mips/alchemy/devboards/db1550.c
@@ -589,7 +589,7 @@ int __init db1550_dev_setup(void)
 	i2c_register_board_info(0, db1550_i2c_devs,
 				ARRAY_SIZE(db1550_i2c_devs));
 	spi_register_board_info(db1550_spi_devs,
-				ARRAY_SIZE(db1550_i2c_devs));
+				ARRAY_SIZE(db1550_spi_devs));
 
 	c = clk_get(NULL, "psc0_intclk");
 	if (!IS_ERR(c)) {
-- 
2.34.1

Re: [PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1550_dev_setup()

Posted by Thomas Bogendoerfer 1 year, 11 months ago

On Wed, Jan 10, 2024 at 07:09:46PM +0100, Christophe JAILLET wrote:
> When calling spi_register_board_info(),
> 
> Fixes: f869d42e580f ("MIPS: Alchemy: Improved DB1550 support, with audio and serial busses.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  arch/mips/alchemy/devboards/db1550.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/alchemy/devboards/db1550.c b/arch/mips/alchemy/devboards/db1550.c
> index fd91d9c9a252..6c6837181f55 100644
> --- a/arch/mips/alchemy/devboards/db1550.c
> +++ b/arch/mips/alchemy/devboards/db1550.c
> @@ -589,7 +589,7 @@ int __init db1550_dev_setup(void)
>  	i2c_register_board_info(0, db1550_i2c_devs,
>  				ARRAY_SIZE(db1550_i2c_devs));
>  	spi_register_board_info(db1550_spi_devs,
> -				ARRAY_SIZE(db1550_i2c_devs));
> +				ARRAY_SIZE(db1550_spi_devs));
>  
>  	c = clk_get(NULL, "psc0_intclk");
>  	if (!IS_ERR(c)) {
> -- 
> 2.34.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]