[PATCH 0/3] irqchip/gic-v5: Fix some static checker issues

Dan Carpenter posted 3 patches 2 months, 3 weeks ago
Only 0 patches received!
There is a newer version of this series
drivers/irqchip/irq-gic-v5-irs.c |  2 +-
drivers/irqchip/irq-gic-v5-its.c | 18 +++++++++++++-----
2 files changed, 14 insertions(+), 6 deletions(-)
[PATCH 0/3] irqchip/gic-v5: Fix some static checker issues
Posted by Dan Carpenter 2 months, 3 weeks ago
These are few things that Smatch complained about.  I have not tested
these patches.  Patch 3 in particular probably needs to be reviewed
more carefully.

Dan Carpenter (3):
  irqchip/gic-v5: Delete a stray tab
  irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
    error handling
  irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain_alloc()

 drivers/irqchip/irq-gic-v5-irs.c |  2 +-
 drivers/irqchip/irq-gic-v5-its.c | 18 +++++++++++++-----
 2 files changed, 14 insertions(+), 6 deletions(-)

-- 
2.47.2
Re: [PATCH 0/3] irqchip/gic-v5: Fix some static checker issues
Posted by Lorenzo Pieralisi 2 months, 3 weeks ago
On Wed, Jul 16, 2025 at 02:37:16PM -0500, Dan Carpenter wrote:
> These are few things that Smatch complained about.  I have not tested
> these patches.  Patch 3 in particular probably needs to be reviewed
> more carefully.

Thanks a lot Dan for reporting (and fixing) them. I had a look
at the patches, [1-2] are obviously correct, patch 3 seems correct
too albeit it could be split in two and I need to test the error
handling loop.

I don't know at this stage what's best wrt applying them (where and
how).

Thanks again,
Lorenzo

> 
> Dan Carpenter (3):
>   irqchip/gic-v5: Delete a stray tab
>   irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
>     error handling
>   irqchip/gic-v5: Fix error handling in gicv5_its_irq_domain_alloc()
> 
>  drivers/irqchip/irq-gic-v5-irs.c |  2 +-
>  drivers/irqchip/irq-gic-v5-its.c | 18 +++++++++++++-----
>  2 files changed, 14 insertions(+), 6 deletions(-)
> 
> -- 
> 2.47.2
>