Hi all, I forgot to include the changelog in my previous patch cover letter (https://lore.kernel.org/linux-leds/20250604225838.102910-1-linux@timmermann.space/T/#t). Here is the changelog: Changes in v3: - Fixed an extra whitespace in the dt bindings documentation. - Sent patch to all related lists and maintainers. - Link to v2: https://lore.kernel.org/lkml/20250531120715.302870-4-linux@timmermann.space/ Changes in v2: - Fixed reading led subnodes in dt incorrectly, which caused wrong numbering and a segfault when removing the driver module - Fixed calling of_property_read_u8 with an int, causing a compiler error - Added more error checking during writes to the i2c bus - Link to v1: https://lore.kernel.org/linux-leds/20250530184219.78085-3-linux@timmermann.space/ Please let me know if any further details are needed. Thanks! Lukas Timmermann Am 05.06.25 um 00:58 schrieb Lukas Timmermann: > This patch adds basic support for the as3668 driver IC via I2C interface. > The IC is capable of driving four individual LEDs up to 25.5mA per > channel. Hardware blinking would be theoretically possible, but this chip > only supports a few set on/off-delays which makes using that feature > unfeasable, therefore my driver doesn't offer that capability. > It's intended applications is in mobile devices such as phones, > tablets and cameras. This driver was tested and is working on > a samsung-manta which is running postmarketOS with a near mainline kernel. > > This is v3 of the patch series adding support for the as3668 LED driver. > I am sending v3 because I discovered major issues in v1 that required > correction before review and made some fixes in my workflow during v2. > > Please note: This is my first suggested patch to the kernel. > checkpatch.pl runs without warnings or errors. > I've read the docs in regards to the led subsystem, > coding style and submission of patches, > but I'm still a bit unsure about the general workflow. > > I will try my best. > > Signed-off-by: Lukas Timmermann <linux@timmermann.space> > > Lukas Timmermann (2): > leds: as3668: Driver for the ams Osram 4-channel i2c LED driver > dt-bindings: leds: Add new as3668 support > > .../devicetree/bindings/leds/leds-as3668.yaml | 76 +++++++ > MAINTAINERS | 6 + > drivers/leds/Kconfig | 14 ++ > drivers/leds/Makefile | 1 + > drivers/leds/leds-as3668.c | 196 ++++++++++++++++++ > 5 files changed, 293 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-as3668.yaml > create mode 100644 drivers/leds/leds-as3668.c >
© 2016 - 2025 Red Hat, Inc.