include: events: remove spaces after '(' and before ')'

[PATCH] include: events: remove spaces after '(' and before ')'

Posted by sunran001@208suo.com 2 years, 6 months ago

Fix four occurrences of the checkpatch error:

ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  include/trace/events/nmi.h | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/trace/events/nmi.h b/include/trace/events/nmi.h
index 18e0411398ba..99abd0bc8ebd 100644
--- a/include/trace/events/nmi.h
+++ b/include/trace/events/nmi.h
@@ -15,9 +15,9 @@ TRACE_EVENT(nmi_handler,
  	TP_ARGS(handler, delta_ns, handled),

  	TP_STRUCT__entry(
-		__field(	void *,		handler	)
-		__field(	s64,		delta_ns)
-		__field(	int,		handled	)
+		__field(void *,	handler)
+		__field(s64, delta_ns)
+		__field(int, handled)
  	),

  	TP_fast_assign(

Re: [PATCH] include: events: remove spaces after '(' and before ')'

Posted by Steven Rostedt 2 years, 6 months ago

On Wed, 19 Jul 2023 11:21:03 +0800
sunran001@208suo.com wrote:

> Fix four occurrences of the checkpatch error:
> 
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
> 
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   include/trace/events/nmi.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/trace/events/nmi.h b/include/trace/events/nmi.h
> index 18e0411398ba..99abd0bc8ebd 100644
> --- a/include/trace/events/nmi.h
> +++ b/include/trace/events/nmi.h
> @@ -15,9 +15,9 @@ TRACE_EVENT(nmi_handler,
>   	TP_ARGS(handler, delta_ns, handled),
> 
>   	TP_STRUCT__entry(
> -		__field(	void *,		handler	)
> -		__field(	s64,		delta_ns)
> -		__field(	int,		handled	)
> +		__field(void *,	handler)
> +		__field(s64, delta_ns)
> +		__field(int, handled)

NACK!

Which version looks better?

checkpatch.pl fails horribly on TRACE_EVENT macros. DON'T MODIFY THEM!

-- Steve

>   	),
> 
>   	TP_fast_assign(