[PATCH] iio: multiplexer: Remove an unused field in struct mux

Christophe JAILLET posted 1 patch 1 year, 7 months ago
drivers/iio/multiplexer/iio-mux.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] iio: multiplexer: Remove an unused field in struct mux
Posted by Christophe JAILLET 1 year, 7 months ago
In "struct mux", the 'indio_dev' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.

It was added in the initial commit 7ba9df54b091 ("iio: multiplexer: new iio
category and iio-mux driver") but was never used.
---
 drivers/iio/multiplexer/iio-mux.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
index edd8c69f6d2e..2953403bef53 100644
--- a/drivers/iio/multiplexer/iio-mux.c
+++ b/drivers/iio/multiplexer/iio-mux.c
@@ -30,7 +30,6 @@ struct mux {
 	int cached_state;
 	struct mux_control *control;
 	struct iio_channel *parent;
-	struct iio_dev *indio_dev;
 	struct iio_chan_spec *chan;
 	struct iio_chan_spec_ext_info *ext_info;
 	struct mux_child *child;
-- 
2.44.0
Re: [PATCH] iio: multiplexer: Remove an unused field in struct mux
Posted by Jonathan Cameron 1 year, 7 months ago
On Wed,  1 May 2024 11:41:54 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> In "struct mux", the 'indio_dev' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied,

Thanks,

> ---
> Compile tested only.
> 
> It was added in the initial commit 7ba9df54b091 ("iio: multiplexer: new iio
> category and iio-mux driver") but was never used.
> ---
>  drivers/iio/multiplexer/iio-mux.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index edd8c69f6d2e..2953403bef53 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -30,7 +30,6 @@ struct mux {
>  	int cached_state;
>  	struct mux_control *control;
>  	struct iio_channel *parent;
> -	struct iio_dev *indio_dev;
>  	struct iio_chan_spec *chan;
>  	struct iio_chan_spec_ext_info *ext_info;
>  	struct mux_child *child;