cpufreq: armada-8k: Fix off by one in armada_8k_cpufreq_free_table()

[PATCH] cpufreq: armada-8k: Fix off by one in armada_8k_cpufreq_free_table()

Posted by Dan Carpenter 3 months, 1 week ago

The freq_tables[] array has num_possible_cpus() elements so, to avoid an
out of bounds access, this loop should be capped at "< nb_cpus" instead
of "<= nb_cpus".  The freq_tables[] array is allocated in
armada_8k_cpufreq_init().

Cc: stable@vger.kernel.org
Fixes: f525a670533d ("cpufreq: ap806: add cpufreq driver for Armada 8K")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/cpufreq/armada-8k-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/armada-8k-cpufreq.c b/drivers/cpufreq/armada-8k-cpufreq.c
index 006f4c554dd7..d96c1718f7f8 100644
--- a/drivers/cpufreq/armada-8k-cpufreq.c
+++ b/drivers/cpufreq/armada-8k-cpufreq.c
@@ -103,7 +103,7 @@ static void armada_8k_cpufreq_free_table(struct freq_table *freq_tables)
 {
 	int opps_index, nb_cpus = num_possible_cpus();
 
-	for (opps_index = 0 ; opps_index <= nb_cpus; opps_index++) {
+	for (opps_index = 0 ; opps_index < nb_cpus; opps_index++) {
 		int i;
 
 		/* If cpu_dev is NULL then we reached the end of the array */
-- 
2.47.2

Re: [PATCH] cpufreq: armada-8k: Fix off by one in armada_8k_cpufreq_free_table()

Posted by Viresh Kumar 3 months, 1 week ago

On 01-07-25, 17:30, Dan Carpenter wrote:
> The freq_tables[] array has num_possible_cpus() elements so, to avoid an
> out of bounds access, this loop should be capped at "< nb_cpus" instead
> of "<= nb_cpus".  The freq_tables[] array is allocated in
> armada_8k_cpufreq_init().
> 
> Cc: stable@vger.kernel.org
> Fixes: f525a670533d ("cpufreq: ap806: add cpufreq driver for Armada 8K")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/cpufreq/armada-8k-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

-- 
viresh