[PATCH 1/2] spi: sg2044-nor: fix signedness bug in sg2044_spifmc_write()

Dan Carpenter posted 2 patches 11 months ago
[PATCH 1/2] spi: sg2044-nor: fix signedness bug in sg2044_spifmc_write()
Posted by Dan Carpenter 11 months ago
The "ret" variable needs to be signed for the error handling to work.
It should be type int, since it only holds zero and negative error
codes.

Fixes: de16c322eefb ("spi: sophgo: add SG2044 SPI NOR controller driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/spi/spi-sg2044-nor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-sg2044-nor.c b/drivers/spi/spi-sg2044-nor.c
index 454153a63b42..baa4cf677663 100644
--- a/drivers/spi/spi-sg2044-nor.c
+++ b/drivers/spi/spi-sg2044-nor.c
@@ -216,7 +216,7 @@ static ssize_t sg2044_spifmc_write(struct sg2044_spifmc *spifmc,
 	size_t xfer_size;
 	const u8 *dout = op->data.buf.out;
 	int i, offset;
-	size_t ret;
+	int ret;
 	u32 reg;
 
 	reg = sg2044_spifmc_init_reg(spifmc);
-- 
2.47.2
Re: [PATCH 1/2] spi: sg2044-nor: fix signedness bug in sg2044_spifmc_write()
Posted by Tudor Ambarus 11 months ago
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>