[PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h>

Uwe Kleine-König (The Capable Hub) posted 1 patch 1 month ago
drivers/fpga/dfl.h | 1 -
1 file changed, 1 deletion(-)
[PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h>
Posted by Uwe Kleine-König (The Capable Hub) 1 month ago
None of the c files that #include drivers/fpga/dfl.h (either directly or
via drivers/fpga/dfl-afu.h) actually need <linux/mod_devicetable.h>.

There is drivers/fpga/dfl-pci.c using pci_device_id, which is provided
by <linux/pci.h> and drivers/fpga/dfl.c using dfl_device_id which is
already provided by <linux/dfl.h>. No other structs traditionally
defined in <linux/mod_devicetable.h> are used by these drivers.

So the #include can just be dropped.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/fpga/dfl.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
index 9549f63b00eb..9a65617bb870 100644
--- a/drivers/fpga/dfl.h
+++ b/drivers/fpga/dfl.h
@@ -23,7 +23,6 @@
 #include <linux/interrupt.h>
 #include <linux/iopoll.h>
 #include <linux/io-64-nonatomic-lo-hi.h>
-#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/uuid.h>

base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
-- 
2.55.0.11.g153666a7d9bb

Re: [PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h>
Posted by Xu Yilun 2 weeks, 5 days ago
On Sat, Aug 22, 2026 at 04:05:35PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> None of the c files that #include drivers/fpga/dfl.h (either directly or
> via drivers/fpga/dfl-afu.h) actually need <linux/mod_devicetable.h>.
> 
> There is drivers/fpga/dfl-pci.c using pci_device_id, which is provided
> by <linux/pci.h> and drivers/fpga/dfl.c using dfl_device_id which is
> already provided by <linux/dfl.h>. No other structs traditionally
> defined in <linux/mod_devicetable.h> are used by these drivers.
> 
> So the #include can just be dropped.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Reviewed-by: Xu Yilun <yilun.xu@intel.com>

Applied to for-next. Thanks.

> ---
>  drivers/fpga/dfl.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 9549f63b00eb..9a65617bb870 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -23,7 +23,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/iopoll.h>
>  #include <linux/io-64-nonatomic-lo-hi.h>
> -#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/uuid.h>
> 
> base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
> -- 
> 2.55.0.11.g153666a7d9bb
> 
>