[v1] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

[PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

Posted by Daniel Abrecht 1 year, 11 months ago

In U-Boot, the default for DMI vendor / product if not set is "Unknown" 
and "Unknown Product".
See 
https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272

This patch adds them to the dmi_blacklist.

Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
---
  sound/soc/soc-core.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f8524b5bfb33..aa1a31abbe3a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
      "Board Manufacturer",
      "Board Vendor Name",
      "Board Product Name",
+    "Unknown",
+    "Unknown Product",
      NULL,    /* terminator */
  };

-- 
2.39.2

Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

Posted by Jaroslav Kysela 1 year, 11 months ago

On 17. 01. 24 13:14, Daniel Abrecht wrote:
> In U-Boot, the default for DMI vendor / product if not set is "Unknown"
> and "Unknown Product".
> See
> https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
> 
> This patch adds them to the dmi_blacklist.
> 
> Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>

I think that there's a whitespace issue, but for the contents:

Acked-by: Jaroslav Kysela <perex@perex.cz>


> ---
>    sound/soc/soc-core.c | 2 ++
>    1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index f8524b5bfb33..aa1a31abbe3a 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
>        "Board Manufacturer",
>        "Board Vendor Name",
>        "Board Product Name",
> +    "Unknown",
> +    "Unknown Product",
>        NULL,    /* terminator */
>    };
> 

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

Posted by Daniel Abrecht 1 year, 11 months ago

Am 2024-01-17 13:20, schrieb Jaroslav Kysela:
> On 17. 01. 24 13:14, Daniel Abrecht wrote:
>> In U-Boot, the default for DMI vendor / product if not set is 
>> "Unknown"
>> and "Unknown Product".
>> See
>> https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
>> 
>> This patch adds them to the dmi_blacklist.
>> 
>> Signed-off-by: Daniel Abrecht <public@danielabrecht.ch>
> 
> I think that there's a whitespace issue, but for the contents:
> 
> Acked-by: Jaroslav Kysela <perex@perex.cz>

Sorry about the whitespace thing. I'll try again.