1. Patchew
  2. linux
  3. View series

[PATCH] net/mlx5e: Remove unneeded io-mapping.h #include

Christophe JAILLET posted 1 patch 2 years, 9 months ago 
drivers/net/ethernet/mellanox/mlx5/core/cmd.c  | 1 -
drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
drivers/net/ethernet/mellanox/mlx5/core/uar.c  | 1 -
3 files changed, 3 deletions(-)
[PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
Posted by Christophe JAILLET 2 years, 9 months ago 
The mlx5 net files don't use io_mapping functionalities. So there is no
point in including <linux/io-mapping.h>.
Remove it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/mellanox/mlx5/core/cmd.c  | 1 -
 drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
 drivers/net/ethernet/mellanox/mlx5/core/uar.c  | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
index 74bd05e5dda2..597907fd63f5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
@@ -37,7 +37,6 @@
 #include <linux/slab.h>
 #include <linux/delay.h>
 #include <linux/random.h>
-#include <linux/io-mapping.h>
 #include <linux/mlx5/driver.h>
 #include <linux/mlx5/eq.h>
 #include <linux/debugfs.h>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index 70e8dc305bec..25e87e5d9270 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -37,7 +37,6 @@
 #include <linux/pci.h>
 #include <linux/dma-mapping.h>
 #include <linux/slab.h>
-#include <linux/io-mapping.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
 #include <linux/mlx5/driver.h>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
index 8455e79bc44a..1513112ecec8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
@@ -31,7 +31,6 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/io-mapping.h>
 #include <linux/mlx5/driver.h>
 #include "mlx5_core.h"
 
-- 
2.34.1
Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
Posted by Pavan Chebbi 2 years, 9 months ago 
On Sun, Nov 27, 2022 at 9:47 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> The mlx5 net files don't use io_mapping functionalities. So there is no
> point in including <linux/io-mapping.h>.
> Remove it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/cmd.c  | 1 -
>  drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
>  drivers/net/ethernet/mellanox/mlx5/core/uar.c  | 1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> index 74bd05e5dda2..597907fd63f5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> @@ -37,7 +37,6 @@
>  #include <linux/slab.h>
>  #include <linux/delay.h>
>  #include <linux/random.h>
> -#include <linux/io-mapping.h>
>  #include <linux/mlx5/driver.h>
>  #include <linux/mlx5/eq.h>
>  #include <linux/debugfs.h>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 70e8dc305bec..25e87e5d9270 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -37,7 +37,6 @@
>  #include <linux/pci.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/slab.h>
> -#include <linux/io-mapping.h>
>  #include <linux/interrupt.h>
>  #include <linux/delay.h>
>  #include <linux/mlx5/driver.h>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> index 8455e79bc44a..1513112ecec8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> @@ -31,7 +31,6 @@
>   */
>
>  #include <linux/kernel.h>
> -#include <linux/io-mapping.h>
>  #include <linux/mlx5/driver.h>
>  #include "mlx5_core.h"
>
> --
> 2.34.1
>

Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
Posted by Pavan Chebbi 2 years, 9 months ago 
Though I think having the target tree specified conventionally in the
subject line [PATCH net] would be more complying with the process.

On Mon, Nov 28, 2022 at 9:57 AM Pavan Chebbi <pavan.chebbi@broadcom.com> wrote:
>
> On Sun, Nov 27, 2022 at 9:47 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> >
> > The mlx5 net files don't use io_mapping functionalities. So there is no
> > point in including <linux/io-mapping.h>.
> > Remove it.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/cmd.c  | 1 -
> >  drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> >  drivers/net/ethernet/mellanox/mlx5/core/uar.c  | 1 -
> >  3 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > index 74bd05e5dda2..597907fd63f5 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > @@ -37,7 +37,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/delay.h>
> >  #include <linux/random.h>
> > -#include <linux/io-mapping.h>
> >  #include <linux/mlx5/driver.h>
> >  #include <linux/mlx5/eq.h>
> >  #include <linux/debugfs.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > index 70e8dc305bec..25e87e5d9270 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > @@ -37,7 +37,6 @@
> >  #include <linux/pci.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/slab.h>
> > -#include <linux/io-mapping.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/delay.h>
> >  #include <linux/mlx5/driver.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > index 8455e79bc44a..1513112ecec8 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > @@ -31,7 +31,6 @@
> >   */
> >
> >  #include <linux/kernel.h>
> > -#include <linux/io-mapping.h>
> >  #include <linux/mlx5/driver.h>
> >  #include "mlx5_core.h"
> >
> > --
> > 2.34.1
> >
>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
Posted by Saeed Mahameed 2 years, 9 months ago 
On 28 Nov 10:27, Pavan Chebbi wrote:
>Though I think having the target tree specified conventionally in the
>subject line [PATCH net] would be more complying with the process.

For such cleanup patches I think [PATCH net-next] is better.

[...]

>>
>> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>

Thanks you Pavan & Christophe
applied to net-next-mlx5 will be sent to net-next shortly

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.