[PATCH] HID: hiddev: Modify Format

wuyonggang001@208suo.com posted 1 patch 2 years, 6 months ago
drivers/hid/usbhid/hiddev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] HID: hiddev: Modify Format
Posted by wuyonggang001@208suo.com 2 years, 6 months ago
Fix the following checkpatch error(s):

ERROR: "inode * inode" should be "inode *inode"
ERROR: "file * file" should be "file *file"

Signed-off-by: Libing Zhang <zhanglibing@cdjrlc.com>
---
  drivers/hid/usbhid/hiddev.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 59cf3ddfdf78..581dc33197d0 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, 
int on)
  /*
   * release file op
   */
-static int hiddev_release(struct inode * inode, struct file * file)
+static int hiddev_release(struct inode *inode, struct file *file)
  {
      struct hiddev_list *list = file->private_data;
      unsigned long flags;
Re: [PATCH] HID: hiddev: Modify Format
Posted by Greg KH 2 years, 6 months ago
On Sun, Jul 16, 2023 at 12:11:11PM +0800, wuyonggang001@208suo.com wrote:
> Fix the following checkpatch error(s):
> 
> ERROR: "inode * inode" should be "inode *inode"
> ERROR: "file * file" should be "file *file"
> 
> Signed-off-by: Libing Zhang <zhanglibing@cdjrlc.com>
> ---
>  drivers/hid/usbhid/hiddev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 59cf3ddfdf78..581dc33197d0 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -213,7 +213,7 @@ static int hiddev_fasync(int fd, struct file *file, int
> on)
>  /*
>   * release file op
>   */
> -static int hiddev_release(struct inode * inode, struct file * file)
> +static int hiddev_release(struct inode *inode, struct file *file)
>  {
>      struct hiddev_list *list = file->private_data;
>      unsigned long flags;

This patch is corrupted and can not be applied.

Please try working on drivers/staging/* files instead first, to give you
a chance to figure out how to do kernel development, before attempting
checkpatch changes on subsystems that might not want them.

good luck!

greg k-h