[PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues

Dan Carpenter posted 3 patches 2 months, 2 weeks ago
Only 0 patches received!
drivers/irqchip/irq-gic-v5-irs.c |  2 +-
drivers/irqchip/irq-gic-v5-its.c | 24 ++++++++++++++++--------
2 files changed, 17 insertions(+), 9 deletions(-)
[PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues
Posted by Dan Carpenter 2 months, 2 weeks ago
These are few things that Smatch complained about.

v2:
I had a wrong goto in patch 3 so there was still a leak.
Improve the naming.

Dan Carpenter (3):
  irqchip/gic-v5: Delete a stray tab
  irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
    error handling
  irqchip/gic-v5: Fix error handling in  gicv5_its_irq_domain_alloc()

 drivers/irqchip/irq-gic-v5-irs.c |  2 +-
 drivers/irqchip/irq-gic-v5-its.c | 24 ++++++++++++++++--------
 2 files changed, 17 insertions(+), 9 deletions(-)

-- 
2.47.2
Re: [PATCH v2 0/3] irqchip/gic-v5: Fix some static checker issues
Posted by Lorenzo Pieralisi 2 months, 2 weeks ago
On Thu, Jul 17, 2025 at 01:45:16PM -0500, Dan Carpenter wrote:
> These are few things that Smatch complained about.
> 
> v2:
> I had a wrong goto in patch 3 so there was still a leak.
> Improve the naming.
> 
> Dan Carpenter (3):
>   irqchip/gic-v5: Delete a stray tab
>   irqchip/gic-v5: Fix forever loop in gicv5_its_create_itt_two_level()
>     error handling
>   irqchip/gic-v5: Fix error handling in  gicv5_its_irq_domain_alloc()
> 
>  drivers/irqchip/irq-gic-v5-irs.c |  2 +-
>  drivers/irqchip/irq-gic-v5-its.c | 24 ++++++++++++++++--------
>  2 files changed, 17 insertions(+), 9 deletions(-)

I reviewed and tested these fixes by injecting an error in the ITS
IRQ domain allocation path for a multi-MSI device - code failed and
the retry (that is not there in the code for obvious reasons)
succeeded, so for the series:

Reviewed-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Tested-by: Lorenzo Pieralisi <lpieralisi@kernel.org>