proc: fix smaps_rollup test after KSM changes

[PATCH] proc: fix smaps_rollup test after KSM changes

Posted by Alexey Dobriyan 2 years, 3 months ago

/proc/${pid}/smaps_rollup is not empty file even if process's address
space is empty, update the test.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 tools/testing/selftests/proc/proc-empty-vm.c |    1 +
 1 file changed, 1 insertion(+)

--- a/tools/testing/selftests/proc/proc-empty-vm.c
+++ b/tools/testing/selftests/proc/proc-empty-vm.c
@@ -267,6 +267,7 @@ static const char g_smaps_rollup[] =
 "Private_Dirty:         0 kB\n"
 "Referenced:            0 kB\n"
 "Anonymous:             0 kB\n"
+"KSM:                   0 kB\n"
 "LazyFree:              0 kB\n"
 "AnonHugePages:         0 kB\n"
 "ShmemPmdMapped:        0 kB\n"

Re: [PATCH] proc: fix smaps_rollup test after KSM changes

Posted by David Hildenbrand 2 years, 3 months ago

On 07.09.23 13:10, Alexey Dobriyan wrote:

Can you clarify in the patch description that we are fixing up a selftest?

"selftests/proc: fixup proc-empty-vm test"

or similar?

> /proc/${pid}/smaps_rollup is not empty file even if process's address
> space is empty, update the test.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>   tools/testing/selftests/proc/proc-empty-vm.c |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> @@ -267,6 +267,7 @@ static const char g_smaps_rollup[] =
>   "Private_Dirty:         0 kB\n"
>   "Referenced:            0 kB\n"
>   "Anonymous:             0 kB\n"
> +"KSM:                   0 kB\n"
>   "LazyFree:              0 kB\n"
>   "AnonHugePages:         0 kB\n"
>   "ShmemPmdMapped:        0 kB\n"
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb