[v2] Makefile: Remove the product of pin_init cleanly in mrporper

[PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

Posted by chenmiao 3 months, 1 week ago

When I enabled Rust compilation, I wanted to clean up its output, so I
used make clean and make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: chenmiao <chenmiao@openatom.club>
---
Changes in V2:
	- Add the `.dylib` to mrproper files.
---
 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b34a1f4c03967..b38b2895e1e4a 100644
--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,8 @@ MRPROPER_FILES += include/config include/generated          \
 		  certs/x509.genkey \
 		  vmlinux-gdb.py \
 		  rpmbuild \
-		  rust/libmacros.so rust/libmacros.dylib
+		  rust/libmacros.so rust/libmacros.dylib \
+		  rust/libpin_init_internal.so rust/libpin_init_internal.dylib
 
 # clean - Delete most, but leave enough to build external modules
 #
-- 
2.43.0

Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

Posted by Miguel Ojeda 2 weeks, 1 day ago

On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
>
> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make clean and make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.
>
> Dongliang Mu <dzm91@hust.edu.cn>
> Signed-off-by: chenmiao <chenmiao@openatom.club>

Applied to `rust-fixes` -- thanks everyone!

    [ Fixed tags as discussed. Reworded slightly. - Miguel ]

Cheers,
Miguel

Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

Posted by Miguel Ojeda 2 weeks, 5 days ago

On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
>
> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make clean and make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.
>
> Dongliang Mu <dzm91@hust.edu.cn>

This line seems broken. Was this meant to be a Reviewed-by, like in v1?

> Signed-off-by: chenmiao <chenmiao@openatom.club>

I think in another patch/thread you mentioned this should be "Chen Miao", right?

No need for a new patch, I can fix both on apply if you agree.

Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
Tamir for the `.dylib` side.

Also, I guess we could backport this:

Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
Cc: stable@vger.kernel.org

Cheers,
Miguel

Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

Posted by Nicolas Schier 2 weeks, 4 days ago

On Sun, Jan 18, 2026 at 11:30:47PM +0100, Miguel Ojeda wrote:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
> >
> > When I enabled Rust compilation, I wanted to clean up its output, so I
> > used make clean and make mrproper. However, I was still able to find that
> > libpin_init_internal.so in the rust directory was not deleted, while
> > all other corresponding outputs were cleared.
> >
> > Dongliang Mu <dzm91@hust.edu.cn>
> 
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
> 
> > Signed-off-by: chenmiao <chenmiao@openatom.club>
> 
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
> 
> No need for a new patch, I can fix both on apply if you agree.
> 
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.
> 
> Also, I guess we could backport this:
> 
> Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> Cc: stable@vger.kernel.org
> 

Can you please update the typo in the subject:
  - prefix: 'rust' or 'kbuild'
  - s/mrporper/mrproper/?

Thanks!

Acked-by: Nicolas Schier <nsc@kernel.org>

Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

Posted by Benno Lossin 2 weeks, 5 days ago

On Sun Jan 18, 2026 at 11:30 PM CET, Miguel Ojeda wrote:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
>>
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make clean and make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>>
>> Dongliang Mu <dzm91@hust.edu.cn>
>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
>
>> Signed-off-by: chenmiao <chenmiao@openatom.club>
>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.

Acked-by: Benno Lossin <lossin@kernel.org>

Cheers,
Benno

Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

Posted by Chen Miao 2 weeks, 5 days ago

在 2026/1/19 06:30, Miguel Ojeda 写道:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make clean and make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>>
>> Dongliang Mu <dzm91@hust.edu.cn>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
Yes, it should be `Reviewed-by`.
>> Signed-off-by: chenmiao <chenmiao@openatom.club>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
Yes, Please modify this to Chen Miao.
>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.
>
> Also, I guess we could backport this:
>
> Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> Cc: stable@vger.kernel.org
>
> Cheers,
> Miguel

If it’s convenient for you, I think your proposal sounds great and I agree.

Thanks for the review.

Regards,

Chen Miao

Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

Posted by Chen Miao 1 month, 3 weeks ago

PING?

On 10/31/2025 10:32 AM, chenmiao wrote:
> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make clean and make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.
>
> Dongliang Mu <dzm91@hust.edu.cn>
> Signed-off-by: chenmiao <chenmiao@openatom.club>
> ---
> Changes in V2:
> 	- Add the `.dylib` to mrproper files.
> ---
>   Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b34a1f4c03967..b38b2895e1e4a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1590,7 +1590,8 @@ MRPROPER_FILES += include/config include/generated          \
>   		  certs/x509.genkey \
>   		  vmlinux-gdb.py \
>   		  rpmbuild \
> -		  rust/libmacros.so rust/libmacros.dylib
> +		  rust/libmacros.so rust/libmacros.dylib \
> +		  rust/libpin_init_internal.so rust/libpin_init_internal.dylib
>   
>   # clean - Delete most, but leave enough to build external modules
>   #