[PATCH sched_ext/for-7.1-fixes] sched_ext: INIT_LIST_HEAD() &sch->all in scx_alloc_and_add_sched()

Tejun Heo posted 1 patch 1 month ago
kernel/sched/ext.c | 1 +
1 file changed, 1 insertion(+)
[PATCH sched_ext/for-7.1-fixes] sched_ext: INIT_LIST_HEAD() &sch->all in scx_alloc_and_add_sched()
Posted by Tejun Heo 1 month ago
On scx_link_sched() error paths (parent disabled, hash insert failure),
&sch->all is never added to scx_sched_all. The cleanup path runs
scx_unlink_sched() unconditionally, which calls list_del_rcu(&sch->all) on a
list_head that was never initialized triggering a corruption warning.

Initialize &sch->all.

Fixes: 54be8de4236a ("sched_ext: Factor out scx_link_sched() and scx_unlink_sched()")
Signed-off-by: Tejun Heo <tj@kernel.org>
---
 kernel/sched/ext.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 9354da79e162..1fb3329ae2b4 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -6643,6 +6643,7 @@ static struct scx_sched *scx_alloc_and_add_sched(struct sched_ext_ops *ops,
 	rcu_assign_pointer(ops->priv, sch);

 	sch->kobj.kset = scx_kset;
+	INIT_LIST_HEAD(&sch->all);

 #ifdef CONFIG_EXT_SUB_SCHED
 	char *buf = kzalloc(PATH_MAX, GFP_KERNEL);
Re: [PATCH sched_ext/for-7.1-fixes] sched_ext: INIT_LIST_HEAD() &sch->all in scx_alloc_and_add_sched()
Posted by Tejun Heo 1 month ago
Hello,

Applied to sched_ext/for-7.1-fixes.

Thanks.

--
tejun