[PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll

Christophe JAILLET posted 1 patch 1 year, 10 months ago
drivers/clk/nxp/clk-lpc18xx-cgu.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll
Posted by Christophe JAILLET 1 year, 10 months ago
In "struct lpc18xx_pll", the 'lock' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
---
 drivers/clk/nxp/clk-lpc18xx-cgu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/nxp/clk-lpc18xx-cgu.c b/drivers/clk/nxp/clk-lpc18xx-cgu.c
index 69ebf65081b8..81efa885069b 100644
--- a/drivers/clk/nxp/clk-lpc18xx-cgu.c
+++ b/drivers/clk/nxp/clk-lpc18xx-cgu.c
@@ -250,7 +250,6 @@ static struct lpc18xx_cgu_base_clk lpc18xx_cgu_base_clks[] = {
 struct lpc18xx_pll {
 	struct		clk_hw hw;
 	void __iomem	*reg;
-	spinlock_t	*lock;
 	u8		flags;
 };
 
-- 
2.44.0
Re: [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll
Posted by Stephen Boyd 1 year, 10 months ago
Quoting Christophe JAILLET (2024-04-01 08:31:53)
> In "struct lpc18xx_pll", the 'lock' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Applied to clk-next
Re: [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll
Posted by Vladimir Zapolskiy 1 year, 10 months ago
On 4/1/24 18:31, Christophe JAILLET wrote:
> In "struct lpc18xx_pll", the 'lock' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thank you for the change!

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

--
Best wishes,
Vladimir