dt-bindings: spi: delete unused required and adjust the item.

[PATCH] dt-bindings: spi: delete unused required and adjust the item.

Posted by Li-hao Kuo 4 years, 4 months ago

delete unused required(clock-name)
adjust position (interrupts)

Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")

Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
---
 Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
index 298eac2..9df08d7 100644
--- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
@@ -47,10 +47,9 @@ required:
   - compatible
   - reg
   - reg-names
-  - interrupts
   - interrupt-names
+  - interrupts
   - clocks
-  - clocks-names
   - resets
   - pinctrl-names
   - pinctrl-0
-- 
2.7.4

Re: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

Posted by Rob Herring 4 years, 4 months ago

On Thu, Feb 17, 2022 at 7:56 PM Li-hao Kuo <lhjeff911@gmail.com> wrote:
>
> delete unused required(clock-name)
> adjust position (interrupts)

Why? This seems like an unnecessary change.

Please write complete sentences that answer why this change is needed,
not what the change is. The diff describes what changed. In this case,
quoting the warning you are fixing is typical.

>
> Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")
>

There should not be a blank line here.

> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 298eac2..9df08d7 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -47,10 +47,9 @@ required:
>    - compatible
>    - reg
>    - reg-names
> -  - interrupts
>    - interrupt-names
> +  - interrupts
>    - clocks
> -  - clocks-names
>    - resets
>    - pinctrl-names
>    - pinctrl-0
> --
> 2.7.4
>

RE: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

Posted by Lh Kuo 郭力豪 4 years, 4 months ago

Hi Mr.Rob Herring :

I am sorry for that.
This patch will fix testing issues as clock names are not used
Checking for a patch will show a warning