[v1] Forwarded: [PATCH] net: skbuff: fix uninitialized memory use in pskb_expand_head()

Forwarded: [PATCH] net: skbuff: fix uninitialized memory use in pskb_expand_head()

syzbot posted 1 patch 3 weeks, 3 days ago

Diff against v1
Download mbox

There is a newer version of this series

net/core/skbuff.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

Forwarded: [PATCH] net: skbuff: fix uninitialized memory use in pskb_expand_head()

Posted by syzbot 3 weeks, 3 days ago

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.

***

Subject: [PATCH] net: skbuff: fix uninitialized memory use in pskb_expand_head()
Author: sohammetha01@gmail.com

pskb_expand_head() allocates a new skb data buffer using
kmalloc_reserve(), which does not initialize memory. skb helpers may
later copy or move padding bytes from the buffer.

Initialize the newly allocated skb buffer to avoid propagating
uninitialized memory.

Reported-by: syzbot+619b9ef527f510a57cfc@syzkaller.appspotmail.com
Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
#syz test

 net/core/skbuff.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index a56133902c0d..b658dcbe0698 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -2280,6 +2280,7 @@ int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
 		gfp_mask |= __GFP_MEMALLOC;
 
 	data = kmalloc_reserve(&size, gfp_mask, NUMA_NO_NODE, NULL);
 	if (!data)
 		goto nodata;
+	memset(data, 0, size);
 	size = SKB_WITH_OVERHEAD(size);
-- 
2.34.1