xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS

[PATCH] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS

Posted by Geert Uytterhoeven 2 months, 1 week ago

Currently, XFS_ONLINE_SCRUB_STATS selects DEBUG_FS.  However, DEBUG_FS
is meant for debugging, and people may want to disable it on production
systems.  Since commit 0ff51a1fd786f47b ("xfs: enable online fsck by
default in Kconfig")), XFS_ONLINE_SCRUB_STATS is enabled by default,
forcing DEBUG_FS enabled too.

Fix this by replacing the selection of DEBUG_FS by a dependency on
DEBUG_FS, which is what most other options controlling the gathering and
exposing of statistics do.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 fs/xfs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index 8930d5254e1da61d..402cf7aad5ca93ab 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -156,7 +156,7 @@ config XFS_ONLINE_SCRUB_STATS
 	bool "XFS online metadata check usage data collection"
 	default y
 	depends on XFS_ONLINE_SCRUB
-	select DEBUG_FS
+	depends on DEBUG_FS
 	help
 	  If you say Y here, the kernel will gather usage data about
 	  the online metadata check subsystem.  This includes the number
-- 
2.43.0

Re: [PATCH] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS

Posted by Carlos Maiolino 1 month, 4 weeks ago

On Mon, 13 Oct 2025 10:48:46 +0200, Geert Uytterhoeven wrote:
> Currently, XFS_ONLINE_SCRUB_STATS selects DEBUG_FS.  However, DEBUG_FS
> is meant for debugging, and people may want to disable it on production
> systems.  Since commit 0ff51a1fd786f47b ("xfs: enable online fsck by
> default in Kconfig")), XFS_ONLINE_SCRUB_STATS is enabled by default,
> forcing DEBUG_FS enabled too.
> 
> Fix this by replacing the selection of DEBUG_FS by a dependency on
> DEBUG_FS, which is what most other options controlling the gathering and
> exposing of statistics do.
> 
> [...]

Applied to for-next, thanks!

[1/1] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS
      commit: f5caeb3689ea2d8a8c0790d9eea68b63e8f15496

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>

Re: [PATCH] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS

Posted by Darrick J. Wong 2 months ago

On Mon, Oct 13, 2025 at 10:48:46AM +0200, Geert Uytterhoeven wrote:
> Currently, XFS_ONLINE_SCRUB_STATS selects DEBUG_FS.  However, DEBUG_FS
> is meant for debugging, and people may want to disable it on production
> systems.  Since commit 0ff51a1fd786f47b ("xfs: enable online fsck by
> default in Kconfig")), XFS_ONLINE_SCRUB_STATS is enabled by default,
> forcing DEBUG_FS enabled too.
> 
> Fix this by replacing the selection of DEBUG_FS by a dependency on
> DEBUG_FS, which is what most other options controlling the gathering and
> exposing of statistics do.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  fs/xfs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index 8930d5254e1da61d..402cf7aad5ca93ab 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -156,7 +156,7 @@ config XFS_ONLINE_SCRUB_STATS
>  	bool "XFS online metadata check usage data collection"
>  	default y
>  	depends on XFS_ONLINE_SCRUB
> -	select DEBUG_FS
> +	depends on DEBUG_FS

Looks ok to me, though I wonder why there are so many "select DEBUG_FS"
in the kernel?

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

>  	help
>  	  If you say Y here, the kernel will gather usage data about
>  	  the online metadata check subsystem.  This includes the number
> -- 
> 2.43.0
> 
>

Re: [PATCH] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS

Posted by Geert Uytterhoeven 2 months ago

Hi Darrick,

On Mon, 13 Oct 2025 at 18:32, Darrick J. Wong <djwong@kernel.org> wrote:
> On Mon, Oct 13, 2025 at 10:48:46AM +0200, Geert Uytterhoeven wrote:
> > Currently, XFS_ONLINE_SCRUB_STATS selects DEBUG_FS.  However, DEBUG_FS
> > is meant for debugging, and people may want to disable it on production
> > systems.  Since commit 0ff51a1fd786f47b ("xfs: enable online fsck by
> > default in Kconfig")), XFS_ONLINE_SCRUB_STATS is enabled by default,
> > forcing DEBUG_FS enabled too.
> >
> > Fix this by replacing the selection of DEBUG_FS by a dependency on
> > DEBUG_FS, which is what most other options controlling the gathering and
> > exposing of statistics do.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> >  fs/xfs/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> > index 8930d5254e1da61d..402cf7aad5ca93ab 100644
> > --- a/fs/xfs/Kconfig
> > +++ b/fs/xfs/Kconfig
> > @@ -156,7 +156,7 @@ config XFS_ONLINE_SCRUB_STATS
> >       bool "XFS online metadata check usage data collection"
> >       default y
> >       depends on XFS_ONLINE_SCRUB
> > -     select DEBUG_FS
> > +     depends on DEBUG_FS
>
> Looks ok to me, though I wonder why there are so many "select DEBUG_FS"
> in the kernel?

I think select is OK for pure debug functionality, which is not enabled
unless really wanted; depends on is better for optional features like
statistics, especially if they default to y.

Alternatively, the "default y" could be dropped from
XFS_ONLINE_SCRUB_STATS?

> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds