For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: Re: [syzbot] [fs?] WARNING in minix_rename
Author: richard120310@gmail.com
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 78f4e737a53e
Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
---
fs/minix/namei.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/minix/namei.c b/fs/minix/namei.c
index 8938536d8d3c..4dfbbfd905d8 100644
--- a/fs/minix/namei.c
+++ b/fs/minix/namei.c
@@ -217,8 +217,13 @@ static int minix_rename(struct mnt_idmap *idmap,
if (err)
goto out_dir;
inode_set_ctime_current(new_inode);
- if (dir_de)
+ if (dir_de) {
drop_nlink(new_inode);
+ if (new_inode->i_nlink == 0) {
+ err = -ESTALE;
+ goto out_dir;
+ }
+ }
inode_dec_link_count(new_inode);
} else {
err = minix_add_link(new_dentry, old_inode);
--
2.43.0