答复: [PATCH] mm/highmem: fix spelling mistakeo

tomorrow Wang (王德明) posted 1 patch 2 years, 7 months ago
Documentation/mm/highmem.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
答复: [PATCH] mm/highmem: fix spelling mistakeo
Posted by tomorrow Wang (王德明) 2 years, 7 months ago
Hi,

 I find only one typo about higmem. And I have modified the subject.

Thanks

> send: Bagas Sanjaya <bagasdotme@gmail.com>
> time: 2023年1月18日 10:21
> to: tomorrow Wang (王德明) <wangdeming@inspur.com>;
> corbet@lwn.net; fmdefrancesco@gmail.com; akpm@linux-foundation.org;
> bigeasy@linutronix.de; ira.weiny@intel.com; rppt@kernel.org
> subject: Re: [PATCH] mm/highmem: fix spelling mistakeo
> 
> On Tue, Jan 17, 2023 at 07:43:56PM -0500, Deming Wang wrote:
> > Substitute occurrencies of "higmem" with "highmem".
> >
> > Signed-off-by: Deming Wang <wangdeming@inspur.com>
> > ---
> >  Documentation/mm/highmem.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/mm/highmem.rst
> > b/Documentation/mm/highmem.rst index 59d1078f53df..7da4a0d175f0
> 100644
> > --- a/Documentation/mm/highmem.rst
> > +++ b/Documentation/mm/highmem.rst
> > @@ -83,7 +83,7 @@ list shows them in order of preference of use.
> >    for pages which are known to not come from ZONE_HIGHMEM. However,
> it is
> >    always safe to use kmap_local_page() / kunmap_local().
> >
> > -  While it is significantly faster than kmap(), for the higmem case
> > it
> > +  While it is significantly faster than kmap(), for the highmem case
> > + it
> >    comes with restrictions about the pointers validity. Contrary to kmap()
> >    mappings, the local mappings are only valid in the context of the caller
> >    and cannot be handed to other contexts. This implies that users
> > must
> 
> Are you sure you have seen the other occurences of higmem in the same doc?
> If so, do s/higmem/highmem/g.
> 
> Also, the patch subject prefix should have been Documentation: mm:
> highmem, and also s/mistakeo/mistake/ in the subject.
> 
> Thanks.
> 
> --
> An old man doll... just what I always wanted! - Clara
From 97b1ab6a569d7517819f9deff63ec3e7c96879c7 Mon Sep 17 00:00:00 2001
From: Deming Wang <wangdeming@inspur.com>
Date: Wed, 18 Jan 2023 10:27:03 +0800
Subject: [PATCH] Documentation: mm: use `s/higmem/highmem/` fix typo for
 highmem

We should use highmem replace higmem.

Signed-off-by: Deming Wang <wangdeming@inspur.com>
---
 Documentation/mm/highmem.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/mm/highmem.rst b/Documentation/mm/highmem.rst
index 59d1078f53df..7da4a0d175f0 100644
--- a/Documentation/mm/highmem.rst
+++ b/Documentation/mm/highmem.rst
@@ -83,7 +83,7 @@ list shows them in order of preference of use.
   for pages which are known to not come from ZONE_HIGHMEM. However, it is
   always safe to use kmap_local_page() / kunmap_local().
 
-  While it is significantly faster than kmap(), for the higmem case it
+  While it is significantly faster than kmap(), for the highmem case it
   comes with restrictions about the pointers validity. Contrary to kmap()
   mappings, the local mappings are only valid in the context of the caller
   and cannot be handed to other contexts. This implies that users must
-- 
2.27.0

Re: 答复: [PATCH] mm/highmem: fix spelling mistakeo
Posted by Bagas Sanjaya 2 years, 7 months ago
On 1/18/23 09:55, tomorrow Wang (王德明) wrote:
> Hi,
> 
>  I find only one typo about higmem. And I have modified the subject.
> 

You send your patch as attachment, please send it inline instead
with git-send-email(1).

Also, please don't top-post; reply inline with appropriate context
instead.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara