vdpa/octeon_ep: Fix error code in octep_process_mbox()

[PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox()

Posted by Dan Carpenter 1 year, 5 months ago

Return -EINVAL for invalid signatures.  Don't return success.

Fixes: 8b6c724cdab8 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
Nag mode: When we add a new driver, then could we use the patch prefix for the
driver not for the subsystem only.

 BAD: net: add driver for abc123
GOOD: net/abc123: add driver for abc123

 drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
index 7fa0491bb201..11bd76ae18cf 100644
--- a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
+++ b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
@@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *bu
 	val = octep_read_sig(mbox);
 	if ((val & 0xFFFF) != MBOX_RSP_SIG) {
 		dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id);
-		return ret;
+		return -EINVAL;
 	}
 
 	val = octep_read_sts(mbox);
-- 
2.43.0

Re: [PATCH] vdpa/octeon_ep: Fix error code in octep_process_mbox()

Posted by Jason Wang 1 year, 5 months ago

On Fri, Jul 12, 2024 at 10:06 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Return -EINVAL for invalid signatures.  Don't return success.
>
> Fixes: 8b6c724cdab8 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> Nag mode: When we add a new driver, then could we use the patch prefix for the
> driver not for the subsystem only.
>
>  BAD: net: add driver for abc123
> GOOD: net/abc123: add driver for abc123
>
>  drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
> index 7fa0491bb201..11bd76ae18cf 100644
> --- a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
> +++ b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
> @@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *bu
>         val = octep_read_sig(mbox);
>         if ((val & 0xFFFF) != MBOX_RSP_SIG) {
>                 dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id);
> -               return ret;
> +               return -EINVAL;
>         }
>
>         val = octep_read_sts(mbox);

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks