On Monday, August 24, 2026 9:15:16 PM CEST Randy Dunlap wrote:
> 
> On 8/21/26 8:32 AM, Mark Brown wrote:
> > Hi all,
> > 
> > Changes since 20260820:
> > 
> > None.
> > 
> > Non-merge commits (relative to Linus' tree): 7073
> >  5989 files changed, 509370 insertions(+), 156446 deletions(-)
> 
> on x86_64 allmodconfig:
> 
> WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'devm_iio_channel_get' from namespace 'IIO_CONSUMER', but does not import it.
> WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'iio_read_channel_processed' from namespace 'IIO_CONSUMER', but does not import it.

Does the appended patch address it?

Interestingly enough, it doesn't complain for me when I build the
thermal tree merged on top of the current mainline.

How exactly do you build it?

---
 drivers/thermal/qcom/qcom-spmi-mbg-tm.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/thermal/qcom/qcom-spmi-mbg-tm.c
+++ b/drivers/thermal/qcom/qcom-spmi-mbg-tm.c
@@ -252,5 +252,6 @@ static struct platform_driver mbg_tm_dri
 };
 module_platform_driver(mbg_tm_driver);
 
+MODULE_IMPORT_NS("IIO_CONSUMER");
 MODULE_DESCRIPTION("PMIC MBG Temperature monitor driver");
 MODULE_LICENSE("GPL");

On Tue, Aug 25, 2026 at 03:27:32PM +0200, Rafael J. Wysocki wrote:
> On Monday, August 24, 2026 9:15:16 PM CEST Randy Dunlap wrote:
> > 
> > On 8/21/26 8:32 AM, Mark Brown wrote:
> > > Hi all,
> > > 
> > > Changes since 20260820:
> > > 
> > > None.
> > > 
> > > Non-merge commits (relative to Linus' tree): 7073
> > >  5989 files changed, 509370 insertions(+), 156446 deletions(-)
> > 
> > on x86_64 allmodconfig:
> > 
> > WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'devm_iio_channel_get' from namespace 'IIO_CONSUMER', but does not import it.
> > WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'iio_read_channel_processed' from namespace 'IIO_CONSUMER', but does not import it.
> 
> Does the appended patch address it?
> 
> Interestingly enough, it doesn't complain for me when I build the
> thermal tree merged on top of the current mainline.

FWIW, I sent a fix for this two weeks ago that explains the semantic
conflict:

  https://lore.kernel.org/20260812-qcom-spmi-mbg-tm-ns-modpost-error-v1-1-d849390d2714@kernel.org/

You will only see it when the IIO tree is merged against the thermal
tree.

-- 
Cheers,
Nathan

On Tue, Aug 25, 2026 at 8:48 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Tue, Aug 25, 2026 at 03:27:32PM +0200, Rafael J. Wysocki wrote:
> > On Monday, August 24, 2026 9:15:16 PM CEST Randy Dunlap wrote:
> > >
> > > On 8/21/26 8:32 AM, Mark Brown wrote:
> > > > Hi all,
> > > >
> > > > Changes since 20260820:
> > > >
> > > > None.
> > > >
> > > > Non-merge commits (relative to Linus' tree): 7073
> > > >  5989 files changed, 509370 insertions(+), 156446 deletions(-)
> > >
> > > on x86_64 allmodconfig:
> > >
> > > WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'devm_iio_channel_get' from namespace 'IIO_CONSUMER', but does not import it.
> > > WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'iio_read_channel_processed' from namespace 'IIO_CONSUMER', but does not import it.
> >
> > Does the appended patch address it?
> >
> > Interestingly enough, it doesn't complain for me when I build the
> > thermal tree merged on top of the current mainline.
>
> FWIW, I sent a fix for this two weeks ago that explains the semantic
> conflict:
>
>   https://lore.kernel.org/20260812-qcom-spmi-mbg-tm-ns-modpost-error-v1-1-d849390d2714@kernel.org/
>
> You will only see it when the IIO tree is merged against the thermal
> tree.

I missed that one, thanks for the pointer!

On 8/25/26 6:27 AM, Rafael J. Wysocki wrote:
> On Monday, August 24, 2026 9:15:16 PM CEST Randy Dunlap wrote:
>>
>> On 8/21/26 8:32 AM, Mark Brown wrote:
>>> Hi all,
>>>
>>> Changes since 20260820:
>>>
>>> None.
>>>
>>> Non-merge commits (relative to Linus' tree): 7073
>>>  5989 files changed, 509370 insertions(+), 156446 deletions(-)
>>
>> on x86_64 allmodconfig:
>>
>> WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'devm_iio_channel_get' from namespace 'IIO_CONSUMER', but does not import it.
>> WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'iio_read_channel_processed' from namespace 'IIO_CONSUMER', but does not import it.
> 
> Does the appended patch address it?

Yes, the warnings are gone now. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

> Interestingly enough, it doesn't complain for me when I build the
> thermal tree merged on top of the current mainline.
> 
> How exactly do you build it?

make O=xx64 allmodconfig
make O=xx64 -s all

> 
> ---
>  drivers/thermal/qcom/qcom-spmi-mbg-tm.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/thermal/qcom/qcom-spmi-mbg-tm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-mbg-tm.c
> @@ -252,5 +252,6 @@ static struct platform_driver mbg_tm_dri
>  };
>  module_platform_driver(mbg_tm_driver);
>  
> +MODULE_IMPORT_NS("IIO_CONSUMER");
>  MODULE_DESCRIPTION("PMIC MBG Temperature monitor driver");
>  MODULE_LICENSE("GPL");
> 
> 
> 
> 

-- 
~Randy

On Tue, Aug 25, 2026 at 6:20 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 8/25/26 6:27 AM, Rafael J. Wysocki wrote:
> > On Monday, August 24, 2026 9:15:16 PM CEST Randy Dunlap wrote:
> >>
> >> On 8/21/26 8:32 AM, Mark Brown wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20260820:
> >>>
> >>> None.
> >>>
> >>> Non-merge commits (relative to Linus' tree): 7073
> >>>  5989 files changed, 509370 insertions(+), 156446 deletions(-)
> >>
> >> on x86_64 allmodconfig:
> >>
> >> WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'devm_iio_channel_get' from namespace 'IIO_CONSUMER', but does not import it.
> >> WARNING: modpost: drivers/thermal/qcom/qcom-spmi-mbg-tm.ko: module uses symbol 'iio_read_channel_processed' from namespace 'IIO_CONSUMER', but does not import it.
> >
> > Does the appended patch address it?
>
> Yes, the warnings are gone now. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>

Cool, thanks!

> > Interestingly enough, it doesn't complain for me when I build the
> > thermal tree merged on top of the current mainline.
> >
> > How exactly do you build it?
>
> make O=xx64 allmodconfig
> make O=xx64 -s all

OK

> > ---
> >  drivers/thermal/qcom/qcom-spmi-mbg-tm.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > --- a/drivers/thermal/qcom/qcom-spmi-mbg-tm.c
> > +++ b/drivers/thermal/qcom/qcom-spmi-mbg-tm.c
> > @@ -252,5 +252,6 @@ static struct platform_driver mbg_tm_dri
> >  };
> >  module_platform_driver(mbg_tm_driver);
> >
> > +MODULE_IMPORT_NS("IIO_CONSUMER");
> >  MODULE_DESCRIPTION("PMIC MBG Temperature monitor driver");
> >  MODULE_LICENSE("GPL");
> >
> >
> >
> >
>
> --
> ~Randy