1. Patchew
  2. linux
  3. [PATCH 0/2] iio: dac: ltc2632: add support for LTC2654 DAC family
  4. View patch

[PATCH 2/2] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings

David Marinović posted 2 patches 4 weeks ago
There is a newer version of this series
[PATCH 2/2] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings
Posted by David Marinović 4 weeks ago 
Add DT compatible strings for the LTC2654 DAC family variants
supported by the ltc2632 driver.

Signed-off-by: David Marinovic <david.marinovic@pupin.rs>
---
  .../devicetree/bindings/iio/dac/lltc,ltc2632.yaml        | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml 
b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
index 733edc7d6d17..7ec663beec1a 100644
--- a/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
@@ -4,14 +4,15 @@
  $id: http://devicetree.org/schemas/iio/dac/lltc,ltc2632.yaml#
  $schema: http://devicetree.org/meta-schemas/core.yaml#

-title: Linear Technology LTC263x 12-/10-/8-Bit Rail-to-Rail DAC
+title: Linear Technology LTC263x 12-/10-/8-Bit, LTC2654 16-/12-Bit, 
Rail-to-Rail DAC

  maintainers:
    - Michael Hennerich <michael.hennerich@analog.com>

  description: |
-  Bindings for the Linear Technology LTC2632/2634/2636 DAC
+  Bindings for the Linear Technology LTC2632/2634/2636/2654 DAC
    Datasheet can be found here: 
https://www.analog.com/media/en/technical-documentation/data-sheets/LTC263[246].pdf
+  Datasheet can be found here: 
https://www.analog.com/media/en/technical-documentation/data-sheets/2654f.pdf

  properties:
    compatible:
@@ -34,6 +35,10 @@ properties:
        - lltc,ltc2636-h12
        - lltc,ltc2636-h10
        - lltc,ltc2636-h8
+      - lltc,ltc2654-l16
+      - lltc,ltc2654-l12
+      - lltc,ltc2654-h16
+      - lltc,ltc2654-h12

    reg:
      maxItems: 1
--
2.50.1




-------- Original Message --------
Subject: [PATCH 0/2] iio: dac: ltc2632: add support for LTC2654 DAC 
family
Date: 10.03.2026 16:27
 From: David Marinović <david.marinovic@pupin.rs>
To: jic23@kernel.org

This patch series adds support for the Linear Technology LTC2654
quad DAC family to the existing ltc2632 driver.

The LTC2654 shares the same 24-bit SPI protocol as the existing
LTC2632/2634/2636 devices, requiring minimal additions to the
driver.

The LTC2654L-16 variant has been tested on a Phytec phyCORE-STM32MP1
board with the DAC connected via SPI1. The driver probes successfully
and all 4 channels are accessible via the IIO sysfs interface.

Patch 1 adds the driver support.
Patch 2 updates the DT bindings documentation.

David Marinovic (2):
   iio: dac: ltc2632: add support for LTC2654 DAC family
   dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings

Signed-off-by: David Marinovic <david.marinovic@pupin.rs>
Re: [PATCH 2/2] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings
Posted by Krzysztof Kozlowski 3 weeks, 6 days ago 
On Tue, Mar 10, 2026 at 04:32:05PM +0100, David Marinović wrote:
> Add DT compatible strings for the LTC2654 DAC family variants
> supported by the ltc2632 driver.

Describe hardware, not driver.

> 
> Signed-off-by: David Marinovic <david.marinovic@pupin.rs>
> ---
>  .../devicetree/bindings/iio/dac/lltc,ltc2632.yaml        | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
> b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
> index 733edc7d6d17..7ec663beec1a 100644
> --- a/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/lltc,ltc2632.yaml
> @@ -4,14 +4,15 @@
>  $id: http://devicetree.org/schemas/iio/dac/lltc,ltc2632.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
> 
> -title: Linear Technology LTC263x 12-/10-/8-Bit Rail-to-Rail DAC
> +title: Linear Technology LTC263x 12-/10-/8-Bit, LTC2654 16-/12-Bit,
> Rail-to-Rail DAC

There are multiple patch errors here. This is unmergeable.

> 
>  maintainers:
>    - Michael Hennerich <michael.hennerich@analog.com>
> 
>  description: |
> -  Bindings for the Linear Technology LTC2632/2634/2636 DAC
> +  Bindings for the Linear Technology LTC2632/2634/2636/2654 DAC
>    Datasheet can be found here: https://www.analog.com/media/en/technical-documentation/data-sheets/LTC263[246].pdf
> +  Datasheet can be found here:
> https://www.analog.com/media/en/technical-documentation/data-sheets/2654f.pdf
> 
>  properties:
>    compatible:
> @@ -34,6 +35,10 @@ properties:
>        - lltc,ltc2636-h12
>        - lltc,ltc2636-h10
>        - lltc,ltc2636-h8
> +      - lltc,ltc2654-l16
> +      - lltc,ltc2654-l12
> +      - lltc,ltc2654-h16
> +      - lltc,ltc2654-h12

Several look compatible to me, so express it with fallback and drop
unneeded entries in the driver.

> 
>    reg:
>      maxItems: 1
> --
> 2.50.1
> 
> 
> 
> 
> -------- Original Message --------
> Subject: [PATCH 0/2] iio: dac: ltc2632: add support for LTC2654 DAC family
> Date: 10.03.2026 16:27
> From: David Marinović <david.marinovic@pupin.rs>
> To: jic23@kernel.org
> 
> This patch series adds support for the Linear Technology LTC2654
> quad DAC family to the existing ltc2632 driver.
> 
> The LTC2654 shares the same 24-bit SPI protocol as the existing
> LTC2632/2634/2636 devices, requiring minimal additions to the
> driver.
> 
> The LTC2654L-16 variant has been tested on a Phytec phyCORE-STM32MP1
> board with the DAC connected via SPI1. The driver probes successfully
> and all 4 channels are accessible via the IIO sysfs interface.
> 
> Patch 1 adds the driver support.
> Patch 2 updates the DT bindings documentation.
> 
> David Marinovic (2):
>   iio: dac: ltc2632: add support for LTC2654 DAC family
>   dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings
> 
> Signed-off-by: David Marinovic <david.marinovic@pupin.rs>

What is this?
Re: [PATCH 2/2] dt-bindings: iio: dac: ltc2632: add LTC2654 compatible strings
Posted by Krzysztof Kozlowski 3 weeks, 6 days ago 
On Tue, Mar 10, 2026 at 04:32:05PM +0100, David Marinović wrote:
> Add DT compatible strings for the LTC2654 DAC family variants
> supported by the ltc2632 driver.
> 
> Signed-off-by: David Marinovic <david.marinovic@pupin.rs>
> ---
>  .../devicetree/bindings/iio/dac/lltc,ltc2632.yaml        | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.