[PATCH] wifi: ata: pata_parport: epat.c Added missing spaces

hanyu001@208suo.com posted 1 patch 2 years, 6 months ago
drivers/ata/pata_parport/epat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] wifi: ata: pata_parport: epat.c Added missing spaces
Posted by hanyu001@208suo.com 2 years, 6 months ago
Added spaces needed in the proper places to address:

./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around 
that '=' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that 
';' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around 
that '<' (ctx:VxV)
./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that 
';' (ctx:VxV)

Signed-off-by: Yu Han <hanyu001@208suo.com>
---
  drivers/ata/pata_parport/epat.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_parport/epat.c 
b/drivers/ata/pata_parport/epat.c
index 016bd96..efc18e2 100644
--- a/drivers/ata/pata_parport/epat.c
+++ b/drivers/ata/pata_parport/epat.c
@@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi)
      epat_disconnect(pi);

      epat_connect(pi);
-    for (j=0;j<2;j++) {
+    for (j = 0; j < 2; j++) {
          WRi(6, 0xa0 + j * 0x10);
          for (k = 0; k < 256; k++) {
              WRi(2, k ^ 0xaa);
Re: [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces
Posted by Damien Le Moal 2 years, 6 months ago
On 7/18/23 16:57, hanyu001@208suo.com wrote:
> Added spaces needed in the proper places to address:

wifi ? I do not think so. Please fix the patch title.

> 
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around 
> that '=' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that 
> ';' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around 
> that '<' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that 
> ';' (ctx:VxV)
> 
> Signed-off-by: Yu Han <hanyu001@208suo.com>
> ---
>   drivers/ata/pata_parport/epat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_parport/epat.c 
> b/drivers/ata/pata_parport/epat.c
> index 016bd96..efc18e2 100644
> --- a/drivers/ata/pata_parport/epat.c
> +++ b/drivers/ata/pata_parport/epat.c
> @@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi)
>       epat_disconnect(pi);
> 
>       epat_connect(pi);
> -    for (j=0;j<2;j++) {
> +    for (j = 0; j < 2; j++) {
>           WRi(6, 0xa0 + j * 0x10);
>           for (k = 0; k < 256; k++) {
>               WRi(2, k ^ 0xaa);

-- 
Damien Le Moal
Western Digital Research
Re: [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces
Posted by Sergei Shtylyov 2 years, 6 months ago
On 7/18/23 10:57 AM, hanyu001@208suo.com wrote:

> Added spaces needed in the proper places to address:
> 
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '=' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around that '<' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that ';' (ctx:VxV)

   Is that from checkpatch.pl?

> Signed-off-by: Yu Han <hanyu001@208suo.com>

   Aside from the issue with the subject:

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

MBR, Sergey