[PATCH] mm: Remove guard around pgd_offset_k() macro

Christophe Leroy posted 1 patch 2 years, 4 months ago
include/linux/pgtable.h | 2 --
1 file changed, 2 deletions(-)
[PATCH] mm: Remove guard around pgd_offset_k() macro
Posted by Christophe Leroy 2 years, 4 months ago
The last architecture redefining pgd_offset_k() was IA64 and it was
removed by commit cf8e8658100d ("arch: Remove Itanium (IA-64)
architecture")

There is no need anymore to guard generic version of pgd_offset_k()
with #ifndef pgd_offset_k

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
 include/linux/pgtable.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
index 85fc7554cd52..bd9c7180718c 100644
--- a/include/linux/pgtable.h
+++ b/include/linux/pgtable.h
@@ -149,9 +149,7 @@ static inline pgd_t *pgd_offset_pgd(pgd_t *pgd, unsigned long address)
  * a shortcut which implies the use of the kernel's pgd, instead
  * of a process's
  */
-#ifndef pgd_offset_k
 #define pgd_offset_k(address)		pgd_offset(&init_mm, (address))
-#endif
 
 /*
  * In many cases it is known that a virtual address is mapped at PMD or PTE
-- 
2.43.0
Re: [PATCH] mm: Remove guard around pgd_offset_k() macro
Posted by David Hildenbrand 2 years, 3 months ago
On 16.03.24 12:52, Christophe Leroy wrote:
> The last architecture redefining pgd_offset_k() was IA64 and it was
> removed by commit cf8e8658100d ("arch: Remove Itanium (IA-64)
> architecture")
> 
> There is no need anymore to guard generic version of pgd_offset_k()
> with #ifndef pgd_offset_k
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
>   include/linux/pgtable.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index 85fc7554cd52..bd9c7180718c 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -149,9 +149,7 @@ static inline pgd_t *pgd_offset_pgd(pgd_t *pgd, unsigned long address)
>    * a shortcut which implies the use of the kernel's pgd, instead
>    * of a process's
>    */
> -#ifndef pgd_offset_k
>   #define pgd_offset_k(address)		pgd_offset(&init_mm, (address))
> -#endif
>   
>   /*
>    * In many cases it is known that a virtual address is mapped at PMD or PTE

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb