[PATCH 12/34] rcu: Remove now-empty rcu_tasks_trace_torture_stats_print() function

Paul E. McKenney posted 34 patches 1 week, 1 day ago
There is a newer version of this series
[PATCH 12/34] rcu: Remove now-empty rcu_tasks_trace_torture_stats_print() function
Posted by Paul E. McKenney 1 week, 1 day ago
The rcu_tasks_trace_torture_stats_print() is used by rcuscale to diagnose
bugs involving the RCU Tasks Trace grace-period kthread, which now no
longer exists.  This commit therefore removes this function.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: <bpf@vger.kernel.org>
---
 include/linux/rcupdate.h | 4 ----
 kernel/rcu/rcuscale.c    | 6 ------
 kernel/rcu/tasks.h       | 7 -------
 3 files changed, 17 deletions(-)

diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index 7611730e34bc33..f3a7478bab2e26 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -175,10 +175,6 @@ void rcu_tasks_torture_stats_print(char *tt, char *tf);
 # define synchronize_rcu_tasks synchronize_rcu
 # endif
 
-# ifdef CONFIG_TASKS_TRACE_RCU
-void rcu_tasks_trace_torture_stats_print(char *tt, char *tf);
-# endif
-
 #define rcu_tasks_qs(t, preempt) do { rcu_tasks_classic_qs((t), (preempt)); } while (0)
 
 # ifdef CONFIG_TASKS_RUDE_RCU
diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
index b521d04559927a..16ba9050dab66b 100644
--- a/kernel/rcu/rcuscale.c
+++ b/kernel/rcu/rcuscale.c
@@ -400,11 +400,6 @@ static void tasks_trace_scale_read_unlock(int idx)
 	rcu_read_unlock_trace();
 }
 
-static void rcu_tasks_trace_scale_stats(void)
-{
-	rcu_tasks_trace_torture_stats_print(scale_type, SCALE_FLAG);
-}
-
 static struct rcu_scale_ops tasks_tracing_ops = {
 	.ptype		= RCU_TASKS_FLAVOR,
 	.init		= rcu_sync_scale_init,
@@ -417,7 +412,6 @@ static struct rcu_scale_ops tasks_tracing_ops = {
 	.sync		= synchronize_rcu_tasks_trace,
 	.exp_sync	= synchronize_rcu_tasks_trace,
 	.rso_gp_kthread	= get_rcu_tasks_trace_gp_kthread,
-	.stats		= IS_ENABLED(CONFIG_TINY_RCU) ? NULL : rcu_tasks_trace_scale_stats,
 	.name		= "tasks-tracing"
 };
 
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index 7a8c1fd9addb7a..4fb61b3c78283d 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -1467,13 +1467,6 @@ void __init rcu_tasks_trace_suppress_unused(void)
 	rcu_tasks_torture_stats_print_generic(NULL, NULL, NULL, NULL);
 }
 
-#if !defined(CONFIG_TINY_RCU)
-void rcu_tasks_trace_torture_stats_print(char *tt, char *tf)
-{
-}
-EXPORT_SYMBOL_GPL(rcu_tasks_trace_torture_stats_print);
-#endif // !defined(CONFIG_TINY_RCU)
-
 struct task_struct *get_rcu_tasks_trace_gp_kthread(void)
 {
 	return NULL;
-- 
2.40.1