dax: Remove an unused field in struct dax_operations

[PATCH] dax: Remove an unused field in struct dax_operations

Posted by Christophe JAILLET 1 year, 5 months ago

.dax_supported() was apparently removed by commit 7b0800d00dae ("dax:
remove dax_capable") on 2021-11.

Remove the now unused function pointer from the struct dax_operations.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Slightly compile tested only, but "git grep dax_supported" now returns
nothing.
---
 include/linux/dax.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/linux/dax.h b/include/linux/dax.h
index 9d3e3327af4c..df41a0017b31 100644
--- a/include/linux/dax.h
+++ b/include/linux/dax.h
@@ -27,12 +27,6 @@ struct dax_operations {
 	 */
 	long (*direct_access)(struct dax_device *, pgoff_t, long,
 			enum dax_access_mode, void **, pfn_t *);
-	/*
-	 * Validate whether this device is usable as an fsdax backing
-	 * device.
-	 */
-	bool (*dax_supported)(struct dax_device *, struct block_device *, int,
-			sector_t, sector_t);
 	/* zero_page_range: required operation. Zero page range   */
 	int (*zero_page_range)(struct dax_device *, pgoff_t, size_t);
 	/*
-- 
2.46.0

Re: [PATCH] dax: Remove an unused field in struct dax_operations

Posted by Jan Kara 1 year, 5 months ago

On Sun 01-09-24 17:17:09, Christophe JAILLET wrote:
> .dax_supported() was apparently removed by commit 7b0800d00dae ("dax:
> remove dax_capable") on 2021-11.
> 
> Remove the now unused function pointer from the struct dax_operations.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
> Slightly compile tested only, but "git grep dax_supported" now returns
> nothing.
> ---
>  include/linux/dax.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/dax.h b/include/linux/dax.h
> index 9d3e3327af4c..df41a0017b31 100644
> --- a/include/linux/dax.h
> +++ b/include/linux/dax.h
> @@ -27,12 +27,6 @@ struct dax_operations {
>  	 */
>  	long (*direct_access)(struct dax_device *, pgoff_t, long,
>  			enum dax_access_mode, void **, pfn_t *);
> -	/*
> -	 * Validate whether this device is usable as an fsdax backing
> -	 * device.
> -	 */
> -	bool (*dax_supported)(struct dax_device *, struct block_device *, int,
> -			sector_t, sector_t);
>  	/* zero_page_range: required operation. Zero page range   */
>  	int (*zero_page_range)(struct dax_device *, pgoff_t, size_t);
>  	/*
> -- 
> 2.46.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR