[v1] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags

[PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags

Posted by Pei Xiao 3 months, 2 weeks ago

This silences the following coccinelle warning:
  WARNING: sum of probable bitmasks, consider |

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
 drivers/net/wireless/realtek/rtw88/coex.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index 64904278ddad..37788aca200b 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -1500,23 +1500,23 @@ static u8 rtw_coex_algorithm(struct rtw_dev *rtwdev)
 	case BPM_HFP:
 		algorithm = COEX_ALGO_HFP;
 		break;
-	case           BPM_HID:
-	case BPM_HFP + BPM_HID:
+	case BPM_HID:
+	case BPM_HFP | BPM_HID:
 		algorithm = COEX_ALGO_HID;
 		break;
-	case BPM_HFP           + BPM_A2DP:
-	case           BPM_HID + BPM_A2DP:
-	case BPM_HFP + BPM_HID + BPM_A2DP:
+	case BPM_HFP | BPM_A2DP:
+	case BPM_HID | BPM_A2DP:
+	case BPM_HFP | BPM_HID | BPM_A2DP:
 		algorithm = COEX_ALGO_A2DP_HID;
 		break;
-	case BPM_HFP                      + BPM_PAN:
-	case           BPM_HID            + BPM_PAN:
-	case BPM_HFP + BPM_HID            + BPM_PAN:
+	case BPM_HFP | BPM_PAN:
+	case BPM_HID | BPM_PAN:
+	case BPM_HFP | BPM_HID | BPM_PAN:
 		algorithm = COEX_ALGO_PAN_HID;
 		break;
-	case BPM_HFP           + BPM_A2DP + BPM_PAN:
-	case           BPM_HID + BPM_A2DP + BPM_PAN:
-	case BPM_HFP + BPM_HID + BPM_A2DP + BPM_PAN:
+	case BPM_HFP | BPM_A2DP | BPM_PAN:
+	case BPM_HID | BPM_A2DP | BPM_PAN:
+	case BPM_HFP | BPM_HID | BPM_A2DP | BPM_PAN:
 		algorithm = COEX_ALGO_A2DP_PAN_HID;
 		break;
 	case                                BPM_PAN:
-- 
2.25.1

RE: [PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags

Posted by Ping-Ke Shih 3 months, 2 weeks ago

Pei Xiao <xiaopei01@kylinos.cn> wrote:
> This silences the following coccinelle warning:
>   WARNING: sum of probable bitmasks, consider |
> 
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
>  drivers/net/wireless/realtek/rtw88/coex.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
> index 64904278ddad..37788aca200b 100644
> --- a/drivers/net/wireless/realtek/rtw88/coex.c
> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
> @@ -1500,23 +1500,23 @@ static u8 rtw_coex_algorithm(struct rtw_dev *rtwdev)
>         case BPM_HFP:
>                 algorithm = COEX_ALGO_HFP;
>                 break;
> -       case           BPM_HID:
> -       case BPM_HFP + BPM_HID:
> +       case BPM_HID:
> +       case BPM_HFP | BPM_HID:
>                 algorithm = COEX_ALGO_HID;
>                 break;
> -       case BPM_HFP           + BPM_A2DP:
> -       case           BPM_HID + BPM_A2DP:
> -       case BPM_HFP + BPM_HID + BPM_A2DP:
> +       case BPM_HFP | BPM_A2DP:
> +       case BPM_HID | BPM_A2DP:
> +       case BPM_HFP | BPM_HID | BPM_A2DP:
>                 algorithm = COEX_ALGO_A2DP_HID;
>                 break;
> -       case BPM_HFP                      + BPM_PAN:
> -       case           BPM_HID            + BPM_PAN:
> -       case BPM_HFP + BPM_HID            + BPM_PAN:
> +       case BPM_HFP | BPM_PAN:
> +       case BPM_HID | BPM_PAN:
> +       case BPM_HFP | BPM_HID | BPM_PAN:

Please just replace '+' by '|'. Keep spaces. People can be easier to see the
combination of BT profiles.

>                 algorithm = COEX_ALGO_PAN_HID;
>                 break;
> -       case BPM_HFP           + BPM_A2DP + BPM_PAN:
> -       case           BPM_HID + BPM_A2DP + BPM_PAN:
> -       case BPM_HFP + BPM_HID + BPM_A2DP + BPM_PAN:
> +       case BPM_HFP | BPM_A2DP | BPM_PAN:
> +       case BPM_HID | BPM_A2DP | BPM_PAN:
> +       case BPM_HFP | BPM_HID | BPM_A2DP | BPM_PAN:
>                 algorithm = COEX_ALGO_A2DP_PAN_HID;
>                 break;
>         case                                BPM_PAN:
> --
> 2.25.1