mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA

[PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA

Posted by Geert Uytterhoeven 4 months ago

If CONFIG_NO_DMA=y:

    ERROR: modpost: "dma_free_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!
    ERROR: modpost: "dma_alloc_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!

The driver cannot function without DMA, hence fix this by adding a
dependency on HAS_DMA.

Fixes: 3148d0e5b1c5733d ("mtd: nand: realtek-ecc: Add Realtek external ECC engine support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mtd/nand/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 4a17271076bc1c4a..1e57c8de857825d7 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -63,7 +63,7 @@ config MTD_NAND_ECC_MEDIATEK
 
 config MTD_NAND_ECC_REALTEK
         tristate "Realtek RTL93xx hardware ECC engine"
-        depends on HAS_IOMEM
+        depends on HAS_IOMEM && HAS_DMA
         depends on MACH_REALTEK_RTL || COMPILE_TEST
         select MTD_NAND_ECC
         help
-- 
2.43.0

Re: [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA

Posted by Miquel Raynal 3 months, 2 weeks ago

On Wed, 08 Oct 2025 11:47:15 +0200, Geert Uytterhoeven wrote:
> If CONFIG_NO_DMA=y:
> 
>     ERROR: modpost: "dma_free_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!
>     ERROR: modpost: "dma_alloc_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!
> 
> The driver cannot function without DMA, hence fix this by adding a
> dependency on HAS_DMA.
> 
> [...]

Applied to mtd/fixes, thanks!

[1/1] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA
      commit: 0d9c80aa572182d4b1464826cd77aa8973213216

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

AW: [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA

Posted by markus.stockhausen@gmx.de 4 months ago

> Von: Geert Uytterhoeven <geert@linux-m68k.org> 
> Gesendet: Mittwoch, 8. Oktober 2025 11:47
>
> If CONFIG_NO_DMA=y:
>
>     ERROR: modpost: "dma_free_pages" [drivers/mtd/nand/ecc-realtek.ko]
undefined!
>     ERROR: modpost: "dma_alloc_pages" [drivers/mtd/nand/ecc-realtek.ko]
undefined!
>
> The driver cannot function without DMA, hence fix this by adding a
> dependency on HAS_DMA.
>
> Fixes: 3148d0e5b1c5733d ("mtd: nand: realtek-ecc: Add Realtek external ECC
engine support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thank you.