[PATCH] Input: cypress-sf - Constify struct i2c_device_id

Christophe JAILLET posted 1 patch 6 days, 18 hours ago
drivers/input/keyboard/cypress-sf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Input: cypress-sf - Constify struct i2c_device_id
Posted by Christophe JAILLET 6 days, 18 hours ago
'struct i2c_device_id' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
   6438	    618	      0	   7056	   1b90	drivers/input/keyboard/cypress-sf.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
   6502	    554	      0	   7056	   1b90	drivers/input/keyboard/cypress-sf.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested-only.
---
 drivers/input/keyboard/cypress-sf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/cypress-sf.c b/drivers/input/keyboard/cypress-sf.c
index eb1d0720784d..335b72efc5aa 100644
--- a/drivers/input/keyboard/cypress-sf.c
+++ b/drivers/input/keyboard/cypress-sf.c
@@ -208,7 +208,7 @@ static int cypress_sf_resume(struct device *dev)
 static DEFINE_SIMPLE_DEV_PM_OPS(cypress_sf_pm_ops,
 				cypress_sf_suspend, cypress_sf_resume);
 
-static struct i2c_device_id cypress_sf_id_table[] = {
+static const struct i2c_device_id cypress_sf_id_table[] = {
 	{ CYPRESS_SF_DEV_NAME },
 	{ }
 };
-- 
2.47.0
Re: [PATCH] Input: cypress-sf - Constify struct i2c_device_id
Posted by Dmitry Torokhov 3 days, 7 hours ago
On Fri, Nov 15, 2024 at 05:50:37PM +0100, Christophe JAILLET wrote:
> 'struct i2c_device_id' is not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>    6438	    618	      0	   7056	   1b90	drivers/input/keyboard/cypress-sf.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>    6502	    554	      0	   7056	   1b90	drivers/input/keyboard/cypress-sf.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thank you.

-- 
Dmitry