[v1] Remove unneeded version.h include pointed out by 'make versioncheck'

[Paatch] [staging][atomisp] Remove unneeded version.h include pointed out by 'make versioncheck'

Posted by Jesper Juhl 2 years, 6 months ago

From d0b9a59ac1bc69523b5cc8b2bab0b0e0b4bd0ab6 Mon Sep 17 00:00:00 2001
From: Jesper Juhl <jesperjuhl76@gmail.com>
Date: Mon, 13 Feb 2023 02:52:24 +0100
Subject: [PATCH 05/12] [staging][atomisp] Remove unneeded version.h include
  pointed out by 'make versioncheck'

Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
---
  drivers/staging/media/atomisp/include/linux/atomisp.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/include/linux/atomisp.h b/drivers/staging/media/atomisp/include/linux/atomisp.h
index 3f602b5aaff9..3deffcb81683 100644
--- a/drivers/staging/media/atomisp/include/linux/atomisp.h
+++ b/drivers/staging/media/atomisp/include/linux/atomisp.h
@@ -20,7 +20,6 @@
  #define _ATOM_ISP_H

  #include <linux/types.h>
-#include <linux/version.h>

  /* struct media_device_info.hw_revision */
  #define ATOMISP_HW_REVISION_MASK	0x0000ff00
-- 
2.39.2

Re: [Paatch] [staging][atomisp] Remove unneeded version.h include pointed out by 'make versioncheck'

Posted by Greg Kroah-Hartman 2 years, 6 months ago

On Thu, Feb 16, 2023 at 01:57:45AM +0100, Jesper Juhl wrote:
> > From d0b9a59ac1bc69523b5cc8b2bab0b0e0b4bd0ab6 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> Date: Mon, 13 Feb 2023 02:52:24 +0100
> Subject: [PATCH 05/12] [staging][atomisp] Remove unneeded version.h include
>  pointed out by 'make versioncheck'

Why is this in the body of your email?

> 
> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>

We can not take patches without any changelog text, sorry.

thanks,

greg k-h

Re: [Paatch] [staging][atomisp] Remove unneeded version.h include pointed out by 'make versioncheck'

Posted by Randy Dunlap 2 years, 6 months ago


On 2/15/23 20:52, Greg Kroah-Hartman wrote:
> On Thu, Feb 16, 2023 at 01:57:45AM +0100, Jesper Juhl wrote:
>>> From d0b9a59ac1bc69523b5cc8b2bab0b0e0b4bd0ab6 Mon Sep 17 00:00:00 2001
>> From: Jesper Juhl <jesperjuhl76@gmail.com>
>> Date: Mon, 13 Feb 2023 02:52:24 +0100
>> Subject: [PATCH 05/12] [staging][atomisp] Remove unneeded version.h include
>>  pointed out by 'make versioncheck'
> 
> Why is this in the body of your email?
> 
>>
>> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
> 
> We can not take patches without any changelog text, sorry.

Jesper,

For examples, see

  https://lore.kernel.org/lkml/20220828024003.28873-5-masahiroy@kernel.org/
and
  commit cfb24463a53e.

HTH.
-- 
~Randy