Slackware 15.0 64-bit compiles and runs fine.
Slackware 15.0 32-bit fails to build and gives the "out of memory" error:

cc1: out of memory allocating 180705472 bytes after a total of 284454912
bytes
...
make[4]: *** [scripts/Makefile.build:289:
drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.ho
st.o] Error 1

Patching it with help from Lorenzo Stoakes allows the build to
run:
https://lore.kernel.org/lkml/5882b96e-1287-4390-8174-3316d39038ef@lucifer.local/

And then 32-bit runs fine too.

Richard Narron

On Tue, Sep 10, 2024 at 03:54:18PM -0700, Richard Narron wrote:
> Slackware 15.0 64-bit compiles and runs fine.
> Slackware 15.0 32-bit fails to build and gives the "out of memory" error:
> 
> cc1: out of memory allocating 180705472 bytes after a total of 284454912
> bytes
> ...
> make[4]: *** [scripts/Makefile.build:289:
> drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.ho
> st.o] Error 1
> 
> Patching it with help from Lorenzo Stoakes allows the build to
> run:
> https://lore.kernel.org/lkml/5882b96e-1287-4390-8174-3316d39038ef@lucifer.local/
> 
> And then 32-bit runs fine too.

Great, please help to get that commit merged into Linus's tree and then
I can backport it here.

thanks,

greg k-h

On Wed, 11 Sep 2024, Greg Kroah-Hartman wrote:

> On Tue, Sep 10, 2024 at 03:54:18PM -0700, Richard Narron wrote:
> > Slackware 15.0 64-bit compiles and runs fine.
> > Slackware 15.0 32-bit fails to build and gives the "out of memory" error:
> >
> > cc1: out of memory allocating 180705472 bytes after a total of 284454912
> > bytes
> > ...
> > make[4]: *** [scripts/Makefile.build:289:
> > drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.ho
> > st.o] Error 1
> >
> > Patching it with help from Lorenzo Stoakes allows the build to
> > run:
> > https://lore.kernel.org/lkml/5882b96e-1287-4390-8174-3316d39038ef@lucifer.local/
> >
> > And then 32-bit runs fine too.
>
> Great, please help to get that commit merged into Linus's tree and then
> I can backport it here.

Thanks to Linus and Lorenzo and Hans there is new smaller fix patch in
Linus's tree:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/staging/media/atomisp/pci/sh_css_frac.h?id=7c6a3a65ace70f12b27b1a27c9a69cb791dc6e91

This works with the new 5.15.167 kernel with both 32-bit (x86) and 64-bit
(x86_64) CPUs

Can this be backported?

Thanks

richard@aaazen.com

On Thu, Sep 12, 2024 at 02:54:18PM -0700, Richard Narron wrote:
> On Wed, 11 Sep 2024, Greg Kroah-Hartman wrote:
> 
> > On Tue, Sep 10, 2024 at 03:54:18PM -0700, Richard Narron wrote:
> > > Slackware 15.0 64-bit compiles and runs fine.
> > > Slackware 15.0 32-bit fails to build and gives the "out of memory" error:
> > >
> > > cc1: out of memory allocating 180705472 bytes after a total of 284454912
> > > bytes
> > > ...
> > > make[4]: *** [scripts/Makefile.build:289:
> > > drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.ho
> > > st.o] Error 1
> > >
> > > Patching it with help from Lorenzo Stoakes allows the build to
> > > run:
> > > https://lore.kernel.org/lkml/5882b96e-1287-4390-8174-3316d39038ef@lucifer.local/
> > >
> > > And then 32-bit runs fine too.
> >
> > Great, please help to get that commit merged into Linus's tree and then
> > I can backport it here.
> 
> Thanks to Linus and Lorenzo and Hans there is new smaller fix patch in
> Linus's tree:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/staging/media/atomisp/pci/sh_css_frac.h?id=7c6a3a65ace70f12b27b1a27c9a69cb791dc6e91
> 
> This works with the new 5.15.167 kernel with both 32-bit (x86) and 64-bit
> (x86_64) CPUs
> 
> Can this be backported?

Yes it will, give us a chance to catch up :)

thanks,

greg k-h

On Wed, Sep 11, 2024 at 03:00:20PM GMT, Greg Kroah-Hartman wrote:
> On Tue, Sep 10, 2024 at 03:54:18PM -0700, Richard Narron wrote:
> > Slackware 15.0 64-bit compiles and runs fine.
> > Slackware 15.0 32-bit fails to build and gives the "out of memory" error:
> >
> > cc1: out of memory allocating 180705472 bytes after a total of 284454912
> > bytes
> > ...
> > make[4]: *** [scripts/Makefile.build:289:
> > drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.ho
> > st.o] Error 1
> >
> > Patching it with help from Lorenzo Stoakes allows the build to
> > run:
> > https://lore.kernel.org/lkml/5882b96e-1287-4390-8174-3316d39038ef@lucifer.local/
> >
> > And then 32-bit runs fine too.
>
> Great, please help to get that commit merged into Linus's tree and then
> I can backport it here.
>
> thanks,
>
> greg k-h

Well that's a surprise :) Did we back-port the mitigations for the
MIN()/MAX() combinatorial explosion?

Slightly surprising that those were insufficient if so.

Regardless, will send a patch upstream FWIW and cc stable