[PATCH v1] ACPI: PM: Set .detach in acpi_general_pm_domain definition

Rafael J. Wysocki posted 1 patch 3 months, 3 weeks ago
drivers/acpi/device_pm.c |    4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH v1] ACPI: PM: Set .detach in acpi_general_pm_domain definition
Posted by Rafael J. Wysocki 3 months, 3 weeks ago
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Instead of setting the .detach callback pointer for acpi_general_pm_domain
every time it is attached to a device, which is confusing, set it once
in the definition of acpi_general_pm_domain.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/device_pm.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/acpi/device_pm.c
+++ b/drivers/acpi/device_pm.c
@@ -1362,6 +1362,8 @@
 }
 #endif /* CONFIG_PM_SLEEP */
 
+static void acpi_dev_pm_detach(struct device *dev, bool power_off);
+
 static struct dev_pm_domain acpi_general_pm_domain = {
 	.ops = {
 		.runtime_suspend = acpi_subsys_runtime_suspend,
@@ -1382,6 +1384,7 @@
 		.restore_early = acpi_subsys_restore_early,
 #endif
 	},
+	.detach = acpi_dev_pm_detach,
 };
 
 /**
@@ -1465,7 +1468,6 @@
 		acpi_device_wakeup_disable(adev);
 	}
 
-	dev->pm_domain->detach = acpi_dev_pm_detach;
 	return 1;
 }
 EXPORT_SYMBOL_GPL(acpi_dev_pm_attach);
Re: [PATCH v1] ACPI: PM: Set .detach in acpi_general_pm_domain definition
Posted by Mika Westerberg 3 months, 3 weeks ago
On Mon, Jun 16, 2025 at 08:20:28PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Instead of setting the .detach callback pointer for acpi_general_pm_domain
> every time it is attached to a device, which is confusing, set it once
> in the definition of acpi_general_pm_domain.
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>