[PATCH] soc: qcom: llcc: Use devm_bitmap_zalloc() when applicable

Christophe JAILLET posted 1 patch 4 years, 6 months ago
drivers/soc/qcom/llcc-qcom.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[PATCH] soc: qcom: llcc: Use devm_bitmap_zalloc() when applicable
Posted by Christophe JAILLET 4 years, 6 months ago
'drv_data->bitmap' is a bitmap. So use 'devm_bitmap_zalloc()' to simplify
code, improve the semantic.

This also fixes a spurious indentation.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/soc/qcom/llcc-qcom.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index ec52f29c8867..00274a93406b 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -632,9 +632,8 @@ static int qcom_llcc_probe(struct platform_device *pdev)
 	for (i = 0; i < num_banks; i++)
 		drv_data->offsets[i] = i * BANK_OFFSET_STRIDE;
 
-	drv_data->bitmap = devm_kcalloc(dev,
-	BITS_TO_LONGS(drv_data->max_slices), sizeof(unsigned long),
-						GFP_KERNEL);
+	drv_data->bitmap = devm_bitmap_zalloc(dev, drv_data->max_slices,
+					      GFP_KERNEL);
 	if (!drv_data->bitmap) {
 		ret = -ENOMEM;
 		goto err;
-- 
2.32.0

Re: (subset) [PATCH] soc: qcom: llcc: Use devm_bitmap_zalloc() when applicable
Posted by Bjorn Andersson 4 years, 4 months ago
On Thu, 23 Dec 2021 08:54:41 +0100, Christophe JAILLET wrote:
> 'drv_data->bitmap' is a bitmap. So use 'devm_bitmap_zalloc()' to simplify
> code, improve the semantic.
> 
> This also fixes a spurious indentation.
> 
> 

Applied, thanks!

[1/1] soc: qcom: llcc: Use devm_bitmap_zalloc() when applicable
      commit: a9ff0638a4063e6b8a0aa38e9995826565f3d529

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>