Hi Alex,

> -----Original Message-----
> From: liulongfang <liulongfang@huawei.com>
> Sent: Wednesday, October 16, 2024 2:23 AM
> To: alex.williamson@redhat.com; jgg@nvidia.com; Shameerali Kolothum
> Thodi <shameerali.kolothum.thodi@huawei.com>; Jonathan Cameron
> <jonathan.cameron@huawei.com>
> Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> linuxarm@openeuler.org; liulongfang <liulongfang@huawei.com>
> Subject: [PATCH v10 0/4] debugfs to hisilicon migration driver
> 
> Add a debugfs function to the hisilicon migration driver in VFIO to
> provide intermediate state values and data during device migration.
> 
> When the execution of live migration fails, the user can view the
> status and data during the migration process separately from the
> source and the destination, which is convenient for users to analyze
> and locate problems.

Could you please take another look at this series as it looks like almost there.

Thanks,
Shameer

On Thu, Oct 24, 2024 at 01:18:55PM +0000, Shameerali Kolothum Thodi wrote:
> > Add a debugfs function to the hisilicon migration driver in VFIO to
> > provide intermediate state values and data during device migration.
> > 
> > When the execution of live migration fails, the user can view the
> > status and data during the migration process separately from the
> > source and the destination, which is convenient for users to analyze
> > and locate problems.
> 
> Could you please take another look at this series as it looks like almost there.

Why are we so keen to do this? Nobody else needed a complex debugfs
for their live migration?

Jason

> -----Original Message-----
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Thursday, October 24, 2024 4:28 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> Cc: liulongfang <liulongfang@huawei.com>; alex.williamson@redhat.com;
> Jonathan Cameron <jonathan.cameron@huawei.com>;
> kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> linuxarm@openeuler.org
> Subject: Re: [PATCH v10 0/4] debugfs to hisilicon migration driver
> 
> On Thu, Oct 24, 2024 at 01:18:55PM +0000, Shameerali Kolothum Thodi
> wrote:
> > > Add a debugfs function to the hisilicon migration driver in VFIO to
> > > provide intermediate state values and data during device migration.
> > >
> > > When the execution of live migration fails, the user can view the
> > > status and data during the migration process separately from the
> > > source and the destination, which is convenient for users to analyze
> > > and locate problems.
> >
> > Could you please take another look at this series as it looks like almost
> there.
> 
> Why are we so keen to do this? Nobody else needed a complex debugfs for
> their live migration?

I don't think it is that complex debugfs.  Longfang has found this very helpful in
testing and debug with hardware. 

And hopefully this can be expanded in future with different hardware revisions.

Thanks,
Shameer