ASoC: SOF: topology: Replace devm_kasprintf() call by devm_kstrdup() in sof_copy_tuples()

[PATCH] ASoC: SOF: topology: Replace devm_kasprintf() call by devm_kstrdup() in sof_copy_tuples()

Markus Elfring posted 1 patch 8 months ago

Download mbox

sound/soc/sof/topology.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] ASoC: SOF: topology: Replace devm_kasprintf() call by devm_kstrdup() in sof_copy_tuples()

Posted by Markus Elfring 8 months ago

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 16 Apr 2025 14:44:58 +0200

Use a devm_kstrdup() call instead of a devm_kasprintf() call
in this function implementation because only a single string
should be copied.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/soc/sof/topology.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index e19ba94f2c80..49462140facc 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -572,8 +572,9 @@ static int sof_copy_tuples(struct snd_sof_dev *sdev, struct snd_soc_tplg_vendor_
 
 					tuples[*num_copied_tuples].token = tokens[j].token;
 					tuples[*num_copied_tuples].value.s =
-						devm_kasprintf(sdev->dev, GFP_KERNEL,
-							       "%s", elem->string);
+						devm_kstrdup(sdev->dev,
+							     elem->string,
+							     GFP_KERNEL);
 					if (!tuples[*num_copied_tuples].value.s)
 						return -ENOMEM;
 				} else {
-- 
2.49.0