pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP

[PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP

Posted by Geert Uytterhoeven 9 months ago

The AMD Image Signal Processor GPIO pin control functionality is only
present on AMD platforms with ISP support, and its platform device is
instantiated by the AMD ISP driver.  Hence add a dependency on
DRM_AMD_ISP, to prevent asking the user about this driver when
configuring a kernel that does not support the AMD ISP.

Fixes: e97435ab09f3ad7b ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index cbb81f65c6eb22f0..0b355a7e7eeec412 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -51,6 +51,7 @@ config PINCTRL_AMD
 
 config PINCTRL_AMDISP
 	tristate "AMDISP GPIO pin control"
+	depends on DRM_AMD_ISP || COMPILE_TEST
 	depends on HAS_IOMEM
 	select GPIOLIB
 	select PINCONF
-- 
2.43.0

Re: [PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP

Posted by Linus Walleij 9 months ago

On Tue, Mar 18, 2025 at 2:58 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The AMD Image Signal Processor GPIO pin control functionality is only
> present on AMD platforms with ISP support, and its platform device is
> instantiated by the AMD ISP driver.  Hence add a dependency on
> DRM_AMD_ISP, to prevent asking the user about this driver when
> configuring a kernel that does not support the AMD ISP.
>
> Fixes: e97435ab09f3ad7b ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Patch applied as obviously correct.

Yours,
Linus Walleij