drivers/i2c/busses/i2c-nomadik.c | 1 + 1 file changed, 1 insertion(+)
The OF match table is not NULL-terminated.
Fix this by adding a sentinel to nmk_i2c_eyeq_match_table[].
Fixes: a0d15cc47f29be6d ("i2c: nomadik: switch from of_device_is_compatible() to of_match_device()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/i2c/busses/i2c-nomadik.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index efb33802804fdde8..d2877e4cc28d42c9 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -1075,6 +1075,7 @@ static const struct of_device_id nmk_i2c_eyeq_match_table[] = {
.compatible = "mobileye,eyeq6h-i2c",
.data = (void *)NMK_I2C_EYEQ_FLAG_32B_BUS,
},
+ { /* sentinel */ }
};
static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
--
2.34.1
Hi Geert,
On Fri, Dec 06, 2024 at 09:28:06AM +0100, Geert Uytterhoeven wrote:
> The OF match table is not NULL-terminated.
> Fix this by adding a sentinel to nmk_i2c_eyeq_match_table[].
>
> Fixes: a0d15cc47f29be6d ("i2c: nomadik: switch from of_device_is_compatible() to of_match_device()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
merged to i2c/i2c-host-fixes.
Thanks,
Andi
Hello Geert & all, On Fri Dec 6, 2024 at 9:28 AM CET, Geert Uytterhoeven wrote: > The OF match table is not NULL-terminated. > Fix this by adding a sentinel to nmk_i2c_eyeq_match_table[]. I had the exact same patch pending locally. Sorry and thanks! Reviewed-by: Théo Lebrun <theo.lebrun@bootlin.com> Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
© 2016 - 2025 Red Hat, Inc.