usb: dwc3: qcom: Omit a variable reassignment in dwc3_qcom_probe()

[PATCH] usb: dwc3: qcom: Omit a variable reassignment in dwc3_qcom_probe()

Posted by Markus Elfring 3 months, 2 weeks ago

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 20 Oct 2025 17:17:18 +0200

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete a redundant variable reassignment.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/usb/dwc3/dwc3-qcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index ded2ca86670c..e81011ef130e 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -707,6 +707,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
 	ret = dwc3_core_probe(&probe_data);
 	if (ret)  {
-		ret = dev_err_probe(dev, ret, "failed to register DWC3 Core\n");
+		dev_err_probe(dev, ret, "failed to register DWC3 Core\n");
 		goto clk_disable;
 	}

-- 
2.51.1

Re: [PATCH] usb: dwc3: qcom: Omit a variable reassignment in dwc3_qcom_probe()

Posted by Thinh Nguyen 3 months, 2 weeks ago

On Mon, Oct 20, 2025, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 20 Oct 2025 17:17:18 +0200
> 
> An error code was assigned to a variable and checked accordingly.
> This value was passed to a dev_err_probe() call in an if branch.
> This function is documented in the way that the same value is returned.
> Thus delete a redundant variable reassignment.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/usb/dwc3/dwc3-qcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index ded2ca86670c..e81011ef130e 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -707,6 +707,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>  	ret = dwc3_core_probe(&probe_data);
>  	if (ret)  {
> -		ret = dev_err_probe(dev, ret, "failed to register DWC3 Core\n");
> +		dev_err_probe(dev, ret, "failed to register DWC3 Core\n");
>  		goto clk_disable;
>  	}
>  
> -- 
> 2.51.1
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

BR,
Thinh