[v1] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

[PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

Posted by Tom Lendacky 3 years, 10 months ago

Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
network device driver.

Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 36f0a205c54a..02e0d0464312 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
 
 AMD XGBE DRIVER
 M:	Tom Lendacky <thomas.lendacky@amd.com>
+M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
 L:	netdev@vger.kernel.org
 S:	Supported
 F:	arch/arm64/boot/dts/amd/amd-seattle-xgbe*.dtsi
-- 
2.36.1

Re: [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

Posted by Joe Perches 3 years, 10 months ago

On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
> network device driver.
> 
> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
>  
>  AMD XGBE DRIVER
>  M:	Tom Lendacky <thomas.lendacky@amd.com>
> +M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

While this is a valid email address, get_maintainer assumes
name formats use "first middle last" when parsing a name
before an email address. (look around line 2460 in get_maintainer)

Perhaps this should use quotes around the name like:

M:	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>

Re: [PATCH net-next] MAINTAINERS: Add an additional maintainer to the AMD XGBE driver

Posted by Tom Lendacky 3 years, 9 months ago

On 6/28/22 12:37, Joe Perches wrote:
> On Tue, 2022-06-28 at 08:17 -0500, Tom Lendacky wrote:
>> Add Shyam Sundar S K as an additional maintainer to support the AMD XGBE
>> network device driver.
>>
>> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -1037,6 +1037,7 @@ F:	arch/arm64/boot/dts/amd/
>>   
>>   AMD XGBE DRIVER
>>   M:	Tom Lendacky <thomas.lendacky@amd.com>
>> +M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> 
> While this is a valid email address, get_maintainer assumes
> name formats use "first middle last" when parsing a name
> before an email address. (look around line 2460 in get_maintainer)
> 
> Perhaps this should use quotes around the name like:
> 
> M:	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>

Totally lost this in my Inbox, I'll submit a v2 with the quotes.

Thanks,
Tom

> 
>