lsm: Fix signedness bug in selinux_secid_to_secctx()

[PATCH next] lsm: Fix signedness bug in selinux_secid_to_secctx()

Posted by Dan Carpenter 3 weeks, 1 day ago

The "ret" variable needs to be signed for the error checking to work.

Fixes: 95a3c11eb670 ("lsm: replace context+len with lsm_context")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index eca9674c9478..0ff018f557ac 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -6644,7 +6644,7 @@ static int selinux_ismaclabel(const char *name)
 static int selinux_secid_to_secctx(u32 secid, struct lsm_context *cp)
 {
 	u32 seclen;
-	u32 ret;
+	int ret;
 
 	if (cp) {
 		cp->id = LSM_ID_SELINUX;
-- 
2.45.2

Re: [PATCH next] lsm: Fix signedness bug in selinux_secid_to_secctx()

Posted by Paul Moore 2 weeks, 4 days ago

On Sat, Nov 2, 2024 at 5:31 AM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The "ret" variable needs to be signed for the error checking to work.
>
> Fixes: 95a3c11eb670 ("lsm: replace context+len with lsm_context")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged into lsm/dev-staging, thanks Dan.

-- 
paul-moore.com

Re: [PATCH next] lsm: Fix signedness bug in selinux_secid_to_secctx()

Posted by Casey Schaufler 3 weeks, 1 day ago

On 11/2/2024 2:31 AM, Dan Carpenter wrote:
> The "ret" variable needs to be signed for the error checking to work.

Doh.

Thank you.

Acked-by: Casey Schaufler <casey@schaufler-ca.com>

>
> Fixes: 95a3c11eb670 ("lsm: replace context+len with lsm_context")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index eca9674c9478..0ff018f557ac 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -6644,7 +6644,7 @@ static int selinux_ismaclabel(const char *name)
>  static int selinux_secid_to_secctx(u32 secid, struct lsm_context *cp)
>  {
>  	u32 seclen;
> -	u32 ret;
> +	int ret;
>  
>  	if (cp) {
>  		cp->id = LSM_ID_SELINUX;