perf parse-events: Remove unneeded semicolon

[PATCH] perf parse-events: Remove unneeded semicolon

Posted by baomingtong001@208suo.com 2 years, 7 months ago

./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon

Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
  tools/perf/util/parse-events.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c 
b/tools/perf/util/parse-events.c
index 629f7bd9fd59..42f84f61fabc 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct 
parse_events_state *parse_state,
      if (extended_type && (type == PERF_TYPE_HARDWARE || type == 
PERF_TYPE_HW_CACHE)) {
          assert(perf_pmus__supports_extended_type());
          attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
-    };
+    }

      if (head_config) {
          if (config_attr(&attr, head_config, parse_state->error,

Re: [PATCH] perf parse-events: Remove unneeded semicolon

Posted by Namhyung Kim 2 years, 7 months ago

Hello,

On Wed, Jun 14, 2023 at 1:13 AM <baomingtong001@208suo.com> wrote:
>
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
>
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>   tools/perf/util/parse-events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c
> b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
>       if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {

The format is broken, please fix your mail client not fix wrap long lines.
This time I fixed it manually, but you need to update your config.

Thanks,
Namhyung


>           assert(perf_pmus__supports_extended_type());
>           attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> -    };
> +    }
>
>       if (head_config) {
>           if (config_attr(&attr, head_config, parse_state->error,

Re: [PATCH] perf parse-events: Remove unneeded semicolon

Posted by Namhyung Kim 2 years, 7 months ago

On Tue, Jun 20, 2023 at 3:50 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Hello,
>
> On Wed, Jun 14, 2023 at 1:13 AM <baomingtong001@208suo.com> wrote:
> >
> > ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
> >
> > Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> > ---
> >   tools/perf/util/parse-events.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-events.c
> > b/tools/perf/util/parse-events.c
> > index 629f7bd9fd59..42f84f61fabc 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> > parse_events_state *parse_state,
> >       if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> > PERF_TYPE_HW_CACHE)) {
>
> The format is broken, please fix your mail client not fix wrap long lines.
> This time I fixed it manually, but you need to update your config.

Also there were other whitespace breakages, but applied to
perf-tools-next anyway, thanks!

Re: [PATCH] perf parse-events: Remove unneeded semicolon

Posted by Arnaldo Carvalho de Melo 2 years, 7 months ago

Em Wed, Jun 14, 2023 at 04:13:53PM +0800, baomingtong001@208suo.com escreveu:
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon

Was this detected by some tool? Which one?

- Arnaldo
 
> Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
> ---
>  tools/perf/util/parse-events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
>      if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {
>          assert(perf_pmus__supports_extended_type());
>          attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> -    };
> +    }
> 
>      if (head_config) {
>          if (config_attr(&attr, head_config, parse_state->error,

-- 

- Arnaldo