[PATCH v2] nfc: pn533: purge fragmented skbs during cleanup

raoxu posted 1 patch 5 days ago
drivers/nfc/pn533/pn533.c | 1 +
1 file changed, 1 insertion(+)
[PATCH v2] nfc: pn533: purge fragmented skbs during cleanup
Posted by raoxu 5 days ago
From: Xu Rao <raoxu@uniontech.com>

pn53x_common_clean() purges resp_q before freeing the common PN533 state,
but it leaves fragment_skb untouched.  The fragmentation helpers queue
transmit fragments there while sending large initiator or target-mode
frames, and those skbs remain owned by the driver until they are sent or
discarded.

If the device is removed while fragments are still queued, the common
cleanup path frees the PN533 state without releasing the queued fragment
skbs, leaking them.

Purge fragment_skb during cleanup alongside resp_q.

Fixes: 963a82e07d4e ("NFC: pn533: Split large Tx frames in chunks")
Cc: stable@vger.kernel.org
Signed-off-by: Xu Rao <raoxu@uniontech.com>
---
Changes in v2:
- Split out the queued command cleanup; this patch only fixes the
  fragmented skb leak.
- Add Fixes tags and Cc stable as requested by David Heidelberg.

 drivers/nfc/pn533/pn533.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c
index d7bdbc82e2ba..6db9ec90f594 100644
--- a/drivers/nfc/pn533/pn533.c
+++ b/drivers/nfc/pn533/pn533.c
@@ -2799,6 +2799,7 @@ void pn53x_common_clean(struct pn533 *priv)
 	destroy_workqueue(priv->wq);

 	skb_queue_purge(&priv->resp_q);
+	skb_queue_purge(&priv->fragment_skb);

 	list_for_each_entry_safe(cmd, n, &priv->cmd_queue, queue) {
 		list_del(&cmd->queue);
--
2.50.1