[PATCH] firmware: arm_ffa: Fix struct ffa_indirect_msg_hdr

Viresh Kumar posted 1 patch 6 months, 2 weeks ago
include/linux/arm_ffa.h | 1 +
1 file changed, 1 insertion(+)
[PATCH] firmware: arm_ffa: Fix struct ffa_indirect_msg_hdr
Posted by Viresh Kumar 6 months, 2 weeks ago
As per the spec, one 32 bit reserved entry is missing here, add it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 include/linux/arm_ffa.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h
index 5bded24dc24f..e1634897e159 100644
--- a/include/linux/arm_ffa.h
+++ b/include/linux/arm_ffa.h
@@ -283,6 +283,7 @@ struct ffa_indirect_msg_hdr {
 	u32 offset;
 	u32 send_recv_id;
 	u32 size;
+	u32 res1;
 	uuid_t uuid;
 };
 
-- 
2.31.1.272.g89b43f80a514
Re: [PATCH] firmware: arm_ffa: Fix struct ffa_indirect_msg_hdr
Posted by Sudeep Holla 6 months, 1 week ago
On Tue, 03 Jun 2025 16:38:53 +0530, Viresh Kumar wrote:
> As per the spec, one 32 bit reserved entry is missing here, add it.
>

Applied to sudeep.holla/linux (for-next/ffa/fixes), thanks!

[1/1] firmware: arm_ffa: Fix struct ffa_indirect_msg_hdr
      https://git.kernel.org/sudeep.holla/c/4c46a471be12
--
Regards,
Sudeep
Re: [PATCH] firmware: arm_ffa: Fix struct ffa_indirect_msg_hdr
Posted by Sudeep Holla 6 months, 2 weeks ago
On Tue, Jun 03, 2025 at 04:38:53PM +0530, Viresh Kumar wrote:
> As per the spec, one 32 bit reserved entry is missing here, add it.
> 

Nice catch! Not sure how it was missed.

If there is no objection, we must add

Fixes: 910cc1acc9b4 ("firmware: arm_ffa: Add support for passing UUID in FFA_MSG_SEND2")

I will fix up when applying.

-- 
Regards,
Sudeep
Re: [PATCH] firmware: arm_ffa: Fix struct ffa_indirect_msg_hdr
Posted by Viresh Kumar 6 months, 2 weeks ago
On 03-06-25, 14:00, Sudeep Holla wrote:
> On Tue, Jun 03, 2025 at 04:38:53PM +0530, Viresh Kumar wrote:
> > As per the spec, one 32 bit reserved entry is missing here, add it.
> > 
> 
> Nice catch! Not sure how it was missed.
> 
> If there is no objection, we must add
> 
> Fixes: 910cc1acc9b4 ("firmware: arm_ffa: Add support for passing UUID in FFA_MSG_SEND2")
> 
> I will fix up when applying.

Sure.

-- 
viresh